From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Miaohe Lin <linmiaohe@huawei.com>,
tj@kernel.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup: minor cleanup for cgroup_local_stat_show()
Date: Thu, 3 Aug 2023 10:05:33 -0700 [thread overview]
Message-ID: <20230803100533.a9bdac370de2e8e4bee0f33a@linux-foundation.org> (raw)
In-Reply-To: <20230803142758.GC219857@cmpxchg.org>
On Thu, 3 Aug 2023 10:27:58 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> > @@ -3686,8 +3686,9 @@ static int cpu_stat_show(struct seq_file *seq, void *v)
> > return ret;
> > }
> >
> > -static int __maybe_unused cgroup_local_stat_show(struct seq_file *seq,
> > - struct cgroup *cgrp, int ssid)
> > +#ifdef CONFIG_CGROUP_SCHED
> > +static int cgroup_local_stat_show(struct seq_file *seq,
> > + struct cgroup *cgrp, int ssid)
>
> Andrew, this is based on "sched: add throttled time stat for throttled
> children" in -next (coming in from -tip). Hence the routing through
> you rather than the cgroup tree.
Since switching to the more gitty workflow I have lost the power to
carry patches against -next. I could regain that power I guess, but
this is the first time the requirement has come up.
So for now I'll save this patch away for the next -rc cycle.
next prev parent reply other threads:[~2023-08-03 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 11:31 [PATCH] cgroup: minor cleanup for cgroup_local_stat_show() Miaohe Lin
2023-08-03 14:27 ` Johannes Weiner
2023-08-03 17:05 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-23 3:19 Miaohe Lin
2023-07-25 21:53 ` Tejun Heo
2023-07-26 1:06 ` Miaohe Lin
2023-07-27 11:50 ` Miaohe Lin
2023-07-31 23:47 ` Tejun Heo
2023-08-01 7:48 ` Miaohe Lin
2023-08-02 19:39 ` Tejun Heo
2023-08-03 1:38 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803100533.a9bdac370de2e8e4bee0f33a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox