From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F36C04A6A for ; Thu, 3 Aug 2023 13:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236103AbjHCNG1 (ORCPT ); Thu, 3 Aug 2023 09:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233423AbjHCNF6 (ORCPT ); Thu, 3 Aug 2023 09:05:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BB694C0A; Thu, 3 Aug 2023 06:04:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F03861DA7; Thu, 3 Aug 2023 13:04:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08B47C433CA; Thu, 3 Aug 2023 13:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691067867; bh=rOYRvWzdoY2NDpovm9SKGXhIVs4ZrpNawC8KF3rspWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hGqjHNxIJZDLeldQC/Ynq5wOxIxUkj6CS6BEDCEQHM6+RQa3ezhv5PpCLQwMU9sUN JmUghMQZskkyR3DMBJOJU8/mwzZjFbKlsRIGV14+Glk8xLZrs3I79CiNd1vOrMmyAG WL0GtU5OwO76ZsYghlJ83Cfswdaa22NRWQZvmnbX6w45oHFo9bexeZRgrgfKDFZZfz dLV4Aqc71J338IAGG/AbJzYhkW8qpdgzWP4PJAOInza8jDeTfvxUSQFlPXx4MiWO2k PnmtZeI9ydH1uuf4DIKYn/MuFyoVjVjQUetdWUW14o6PGJus8cu63tZR756gIGr2es pFc1LJiAIZN5Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , Luiz Augusto von Dentz , Sasha Levin , marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org Subject: [PATCH AUTOSEL 6.4 3/4] Bluetooth: MGMT: Use correct address for memcpy() Date: Thu, 3 Aug 2023 09:04:17 -0400 Message-Id: <20230803130419.641865-3-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230803130419.641865-1-sashal@kernel.org> References: <20230803130419.641865-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.4.7 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko [ Upstream commit d1f0a9816f5fbc1316355ec1aa4ddfb9b624cca5 ] In function ‘fortify_memcpy_chk’, inlined from ‘get_conn_info_complete’ at net/bluetooth/mgmt.c:7281:2: include/linux/fortify-string.h:592:25: error: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Werror=attribute-warning] 592 | __read_overflow2_field(q_size_field, size); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors This is due to the wrong member is used for memcpy(). Use correct one. Signed-off-by: Andy Shevchenko Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index f7b2d0971f240..b5a26a32f3323 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -7285,7 +7285,7 @@ static void get_conn_info_complete(struct hci_dev *hdev, void *data, int err) bt_dev_dbg(hdev, "err %d", err); - memcpy(&rp.addr, &cp->addr.bdaddr, sizeof(rp.addr)); + memcpy(&rp.addr, &cp->addr, sizeof(rp.addr)); status = mgmt_status(err); if (status == MGMT_STATUS_SUCCESS) { -- 2.40.1