From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7791DC001DB for ; Thu, 3 Aug 2023 16:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236069AbjHCQIf (ORCPT ); Thu, 3 Aug 2023 12:08:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235759AbjHCQIb (ORCPT ); Thu, 3 Aug 2023 12:08:31 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 389902D54 for ; Thu, 3 Aug 2023 09:08:30 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-7679ea01e16so83699585a.2 for ; Thu, 03 Aug 2023 09:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1691078909; x=1691683709; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+XToHAF3Tp6ttDMOwj4eUjXmrH43hQkGliAE52bu3OI=; b=nwBfuP1EF89+aISDQLUPsPs557pMHRTYHh/moPt/GEUf3VZSegFJN2WLjwtOxNaeVr tELhzCnpQiVVzn/p9TxTM40ypLAI9Wl8Dm00Ma0u6gCG9cYdJZyEwo/8Du3Xb48kiI3S aj+mMtHg5P4dd9nwwPCbs602BbZueBi9x/ZXCX+ClObKOCBNOJ2QGS2u1cys65T6jh4F sdy7Pm6FD7EqT02Lj5dytAzyu/Lm8M/yCK7CYer/QhZjZ1QXAsA3k1m/WtIhfHYpfDaQ JTwBdRXqxtir8UKBvShgRNW5OjaHl24g01HNtAzPqjO+63i2Pwtjedb13yOisZI7uZQ1 KP1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691078909; x=1691683709; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+XToHAF3Tp6ttDMOwj4eUjXmrH43hQkGliAE52bu3OI=; b=a/c8OkOW94WNdQGPdgwu5bwifZWApPMRKG3Lnog6ubzLMAB+4/8hWgIZWDJRdJjeTp KSGnmOJ3cvJKABR+HYFi65DOcZcsrG5YYykrSwQvhAZZbU+WcbbAfX7N68wc3UMsz5mq lXMZBx1O3eSYeor6OZP9LNLWgi1ZHyU3ZBKBL36Xs6NF1PBnNRV0WVUX6ZTHg79T9mHJ pQ3nCrhzJsX5E1IVfOaG7tYAsxKDfJHaiUi8DIqCKTPXNrdyX+7OJhzidNAmH0lG5lB+ pnQQGQxXWE1tnRUwK1UWD9hKODD6PuHtAxmecOyONZxLacYCUXCDcTMlbcEIGhgh0I3p UurA== X-Gm-Message-State: ABy/qLabgPykwIR5RAK/WsMMFYlpIU048PGOO0Z/uX/vQkWmiGZZwCb0 vx6GHxibrYCGi5AFZ9w53leb0A== X-Google-Smtp-Source: APBJJlE/HITWbFDhpZ/D5lR41JynAMCPkaudsb/XHWlqv+SykPhRMLbLhtMkySOs7sEOxK1mOiRSuw== X-Received: by 2002:a37:5a05:0:b0:767:2471:c880 with SMTP id o5-20020a375a05000000b007672471c880mr18403599qkb.28.1691078909290; Thu, 03 Aug 2023 09:08:29 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:9910]) by smtp.gmail.com with ESMTPSA id g16-20020ae9e110000000b0076cb0ed2d7asm14050qkm.24.2023.08.03.09.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 09:08:29 -0700 (PDT) Date: Thu, 3 Aug 2023 12:08:28 -0400 From: Johannes Weiner To: Lucas Karpinski Cc: Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Tejun Heo , Zefan Li , Shuah Khan , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests: cgroup: fix test_kmem_basic slab1 check Message-ID: <20230803160828.GA223746@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 03, 2023 at 12:00:47PM -0400, Lucas Karpinski wrote: > test_kmem_basic creates 100,000 negative dentries, with each one mapping > to a slab object. After memory.high is set, these are reclaimed through > the shrink_slab function call which reclaims all 100,000 entries. The > test passes the majority of the time because when slab1 is calculated, > it is often above 0, however, 0 is also an acceptable value. > > Signed-off-by: Lucas Karpinski Acked-by: Johannes Weiner > @@ -71,7 +71,7 @@ static int test_kmem_basic(const char *root) > > cg_write(cg, "memory.high", "1M"); > slab1 = cg_read_key_long(cg, "memory.stat", "slab "); > - if (slab1 <= 0) > + if (slab1 < 0) > goto cleanup; This conflicts with a recent patch already queued up in -mm: selftests: cgroup: fix test_kmem_basic false positives which adds a sleep(1) between cg_write() and cg_read_key_long(). Can you please rebase on top of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable and re-send the patch with To: Andrew Morton ? Thanks