public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	Rob Clark <robdclark@chromium.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org (open list:SUSPEND TO RAM),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 5/9] PM / QoS: Teach lockdep about dev_pm_qos_mtx locking order
Date: Thu,  3 Aug 2023 15:01:53 -0700	[thread overview]
Message-ID: <20230803220202.78036-6-robdclark@gmail.com> (raw)
In-Reply-To: <20230803220202.78036-1-robdclark@gmail.com>

From: Rob Clark <robdclark@chromium.org>

Annotate dev_pm_qos_mtx to teach lockdep to scream about allocations
that could trigger reclaim under dev_pm_qos_mtx.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/base/power/qos.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c
index 4537d93ddb45..6cb4143d1090 100644
--- a/drivers/base/power/qos.c
+++ b/drivers/base/power/qos.c
@@ -1010,3 +1010,14 @@ void dev_pm_qos_hide_latency_tolerance(struct device *dev)
 	pm_runtime_put(dev);
 }
 EXPORT_SYMBOL_GPL(dev_pm_qos_hide_latency_tolerance);
+
+static int __init dev_pm_qos_init(void)
+{
+	/* Teach lockdep about lock ordering wrt. shrinker: */
+	fs_reclaim_acquire(GFP_KERNEL);
+	might_lock(&dev_pm_qos_mtx);
+	fs_reclaim_release(GFP_KERNEL);
+
+	return 0;
+}
+early_initcall(dev_pm_qos_init);
-- 
2.41.0


  parent reply	other threads:[~2023-08-03 22:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03 22:01 [PATCH v3 0/9] drm/msm+PM+icc: Make job_run() reclaim-safe Rob Clark
2023-08-03 22:01 ` [PATCH v3 1/9] PM / devfreq: Drop unneed locking to appease lockdep Rob Clark
2023-08-03 22:01 ` [PATCH v3 2/9] PM / devfreq: Teach lockdep about locking order Rob Clark
2023-08-03 22:01 ` [PATCH v3 3/9] PM / QoS: Fix constraints alloc vs reclaim locking Rob Clark
2023-08-04 17:07   ` Rafael J. Wysocki
2023-08-04 18:38     ` Rob Clark
2023-08-04 19:11       ` Rafael J. Wysocki
2023-08-04 20:37         ` Rob Clark
2023-08-04 20:45           ` Rafael J. Wysocki
2023-08-03 22:01 ` [PATCH v3 4/9] PM / QoS: Decouple request alloc from dev_pm_qos_mtx Rob Clark
2023-08-04  9:29   ` Dan Carpenter
2023-08-03 22:01 ` Rob Clark [this message]
2023-08-03 22:01 ` [PATCH v3 6/9] interconnect: Fix locking for runpm vs reclaim Rob Clark
2023-08-03 22:01 ` [PATCH v3 7/9] interconnect: Teach lockdep about icc_bw_lock order Rob Clark
2023-08-03 22:01 ` [PATCH v3 8/9] drm/sched: Add (optional) fence signaling annotation Rob Clark
2023-08-03 22:01 ` [PATCH v3 9/9] drm/msm: Enable fence signalling annotations Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230803220202.78036-6-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=robdclark@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox