From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, "John Stultz" <jstultz@google.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Valentin Schneider" <vschneid@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian Brauner (Microsoft)" <brauner@kernel.org>,
"Mike Christie" <michael.christie@oracle.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
Zqiang <qiang1.zhang@intel.com>,
"Prathu Baronia" <quic_pbaronia@quicinc.com>,
"Sami Tolvanen" <samitolvanen@google.com>
Subject: Re: [PATCH] kthread: unexport __kthread_should_park()
Date: Fri, 4 Aug 2023 01:39:22 -0700 [thread overview]
Message-ID: <202308040138.46EC412@keescook> (raw)
In-Reply-To: <2023080450-handcuff-stump-1d6e@gregkh>
On Fri, Aug 04, 2023 at 08:41:51AM +0200, Greg Kroah-Hartman wrote:
> There are no in-kernel users of __kthread_should_park() so mark it as
> static and do not export it.
>
> Cc: John Stultz <jstultz@google.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: "Arve Hjønnevåg" <arve@android.com>
> Cc: Valentin Schneider <vschneid@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: "Christian Brauner (Microsoft)" <brauner@kernel.org>
> Cc: Mike Christie <michael.christie@oracle.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Zqiang <qiang1.zhang@intel.com>
> Cc: Prathu Baronia <quic_pbaronia@quicinc.com>
> Cc: Sami Tolvanen <samitolvanen@google.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeah. Seems like it got an EXPORT because it was duplicating the
neighboring functions?
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
prev parent reply other threads:[~2023-08-04 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 6:41 [PATCH] kthread: unexport __kthread_should_park() Greg Kroah-Hartman
2023-08-04 8:39 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308040138.46EC412@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=qiang1.zhang@intel.com \
--cc=quic_pbaronia@quicinc.com \
--cc=samitolvanen@google.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox