Re: [PATCH 1/2] watchdog/hardlockup: avoid unused-function warning

Doug Anderson
2023-08-04T14:03:27Z

Hi,

On Fri, Aug 4, 2023 at 6:28 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added hardlockup_all_cpu_backtrace_proc_handler() function is defined
> in some configurations that don't actually call it:
>
> kernel/watchdog.c:112:12: error: 'hardlockup_all_cpu_backtrace_proc_handler' defined but not used [-Werror=unused-function]
> 112 | static int hardlockup_all_cpu_backtrace_proc_handler(struct ctl_table *table, int write,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Hide the definition when either CONFIG_SMP or CONFIG_SYSCTL are disabled and
> the function is not actually needed.
>
> Fixes: 838b3b76220d5 ("watchdog/hardlockup: avoid large stack frames in watchdog_hardlockup_check()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> kernel/watchdog.c | 2 ++
> 1 file changed, 2 insertions(+)

Thanks for the fix. In this case I'll assume that Andrew will drop the
v2 of my patch and replace it with v4 [1], which shouldn't have this
issue.

[4] https://lore.kernel.org/r/20230804065935.v4.2.I501ab68cb926ee33a7c87e063d207abf09b9943c@changeid