From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Valentin Caron <valentin.caron@foss.st.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Amelie Delaunay <amelie.delaunay@foss.st.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] serial: stm32: synchronize RX DMA channel in shutdown
Date: Fri, 4 Aug 2023 15:05:33 +0200 [thread overview]
Message-ID: <2023080414-props-senior-c40a@gregkh> (raw)
In-Reply-To: <20230803130134.155355-7-valentin.caron@foss.st.com>
On Thu, Aug 03, 2023 at 03:01:34PM +0200, Valentin Caron wrote:
> From: Amelie Delaunay <amelie.delaunay@foss.st.com>
>
> In shutdown, RX DMA channel is terminated. If the DMA RX callback is
> scheduled but not yet executed, while a new RX DMA transfer is started, the
> callback can be executed, and then disturb the ongoing RX DMA transfer.
> To avoid such a case, call dmaengine_synchronize in shutdown, after the
> DMA RX channel is terminated.
>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
You can't forward on a patch from someone else and not sign-off on it
yourself :(
Please fix up and resend the series.
thanks,
greg k-h
prev parent reply other threads:[~2023-08-04 13:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 13:01 [PATCH 0/6] serial: stm32: improve DMA pause and resume Valentin Caron
2023-08-03 13:01 ` [PATCH 1/6] serial: stm32: avoid clearing DMAT bit during transfer Valentin Caron
2023-08-03 13:01 ` [PATCH 2/6] serial: stm32: use DMAT as a configuration bit Valentin Caron
2023-08-03 13:01 ` [PATCH 3/6] serial: stm32: modify parameter and rename stm32_usart_rx_dma_enabled Valentin Caron
2023-08-03 13:01 ` [PATCH 4/6] serial: stm32: group dma pause/resume error handling into single function Valentin Caron
2023-08-03 13:01 ` [PATCH 5/6] serial: stm32: replace access to DMAR bit by dmaengine_pause/resume Valentin Caron
2023-08-03 13:01 ` [PATCH 6/6] serial: stm32: synchronize RX DMA channel in shutdown Valentin Caron
2023-08-04 13:05 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080414-props-senior-c40a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=valentin.caron@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox