* [PATCH] hwrng: xgene: Add explicit io.h include
@ 2023-08-04 14:48 Rob Herring
2023-08-05 4:38 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2023-08-04 14:48 UTC (permalink / raw)
To: Olivia Mackall, Herbert Xu; +Cc: kernel test robot, linux-crypto, linux-kernel
Commit 0788257aeebe ("hwrng: Explicitly include correct DT includes")
removed an implicit include of io.h. On most architectures, there's
still an implicit include of it, but not on s390. Enabling COMPILE_TEST
in commit 1ce1cd8208ad ("hwrng: Enable COMPILE_TEST for more drivers")
exposed this.
Fixes: 0788257aeebe ("hwrng: Explicitly include correct DT includes")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308042049.8R2tNRoo-lkp@intel.com/
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/char/hw_random/xgene-rng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
index c25bb169563d..99f4e86ac3e9 100644
--- a/drivers/char/hw_random/xgene-rng.c
+++ b/drivers/char/hw_random/xgene-rng.c
@@ -14,6 +14,7 @@
#include <linux/hw_random.h>
#include <linux/init.h>
#include <linux/interrupt.h>
+#include <linux/io.h>
#include <linux/module.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwrng: xgene: Add explicit io.h include
2023-08-04 14:48 [PATCH] hwrng: xgene: Add explicit io.h include Rob Herring
@ 2023-08-05 4:38 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2023-08-05 4:38 UTC (permalink / raw)
To: Rob Herring; +Cc: Olivia Mackall, kernel test robot, linux-crypto, linux-kernel
On Fri, Aug 04, 2023 at 08:48:44AM -0600, Rob Herring wrote:
> Commit 0788257aeebe ("hwrng: Explicitly include correct DT includes")
> removed an implicit include of io.h. On most architectures, there's
> still an implicit include of it, but not on s390. Enabling COMPILE_TEST
> in commit 1ce1cd8208ad ("hwrng: Enable COMPILE_TEST for more drivers")
> exposed this.
>
> Fixes: 0788257aeebe ("hwrng: Explicitly include correct DT includes")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308042049.8R2tNRoo-lkp@intel.com/
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/char/hw_random/xgene-rng.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-05 4:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04 14:48 [PATCH] hwrng: xgene: Add explicit io.h include Rob Herring
2023-08-05 4:38 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox