From: <yang.yang29@zte.com.cn>
To: <jmaloy@redhat.com>, <davem@davemloft.net>
Cc: <ying.xue@windriver.com>, <edumazet@google.com>,
<kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] net: tipc: add net device refcount tracker for bearer
Date: Fri, 4 Aug 2023 16:53:41 +0800 (CST) [thread overview]
Message-ID: <202308041653414100323@zte.com.cn> (raw)
From: xu xin <xu.xin16@zte.com.cn>
Add net device refcount tracker to the struct tipc_bearer.
Signed-off-by: xu xin <xu.xin16@zte.com.cn>
Reviewed-by: Yang Yang <yang.yang.29@zte.com.cn>
Cc: Kuang Mingfu <kuang.mingfu@zte.com.cn>
---
net/tipc/bearer.c | 10 +++++-----
net/tipc/bearer.h | 1 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 2cde375477e3..01ffd1f2337a 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -426,15 +426,15 @@ int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b,
struct net_device *dev;
/* Find device with specified name */
- dev = dev_get_by_name(net, dev_name);
+ dev = netdev_get_by_name(net, dev_name, &b->devtracker, GFP_KERNEL);
if (!dev)
return -ENODEV;
if (tipc_mtu_bad(dev)) {
- dev_put(dev);
+ netdev_put(dev, &b->devtracker);
return -EINVAL;
}
if (dev == net->loopback_dev) {
- dev_put(dev);
+ netdev_put(dev, &b->devtracker);
pr_info("Enabling <%s> not permitted\n", b->name);
return -EINVAL;
}
@@ -445,7 +445,7 @@ int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b,
tipc_net_init(net, node_id, 0);
}
if (!tipc_own_id(net)) {
- dev_put(dev);
+ netdev_put(dev, &b->devtracker);
pr_warn("Failed to obtain node identity\n");
return -EINVAL;
}
@@ -479,7 +479,7 @@ void tipc_disable_l2_media(struct tipc_bearer *b)
dev_remove_pack(&b->pt);
RCU_INIT_POINTER(dev->tipc_ptr, NULL);
synchronize_net();
- dev_put(dev);
+ netdev_put(dev, &b->devtracker);
}
/**
diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h
index 41eac1ee0c09..1adeaf94aa62 100644
--- a/net/tipc/bearer.h
+++ b/net/tipc/bearer.h
@@ -174,6 +174,7 @@ struct tipc_bearer {
u16 encap_hlen;
unsigned long up;
refcount_t refcnt;
+ netdevice_tracker devtracker;
};
struct tipc_bearer_names {
--
2.15.2
next reply other threads:[~2023-08-04 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 8:53 yang.yang29 [this message]
2023-08-05 11:26 ` [PATCH] net: tipc: add net device refcount tracker for bearer Simon Horman
2023-08-06 19:51 ` Simon Horman
2023-08-07 0:25 ` Tung Quang Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308041653414100323@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox