From: Greg KH <gregkh@linuxfoundation.org>
To: coolrrsh@gmail.com
Cc: broonie@kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] fixes warning
Date: Sat, 5 Aug 2023 08:22:20 +0200 [thread overview]
Message-ID: <2023080507-umbrella-automated-0db9@gregkh> (raw)
In-Reply-To: <20230804200711.65750-2-coolrrsh@gmail.com>
On Sat, Aug 05, 2023 at 01:37:11AM +0530, coolrrsh@gmail.com wrote:
> From: Rajeshwar R Shinde <coolrrsh@gmail.com>
>
> Typecasting the interrupt number from "unsigned int" to "signed int" to compare with 0(signed int by default).
> Declaring interrupt number as "signed int" would violate kernel standards. So typecasting is the possible approach.
> The fix is for spi-mpc52xx.
>
> This fixes warning such as:
> drivers/spi/spi-mpc52xx-psc.c:332:5-13: WARNING: Unsigned expression compared with zero: mps -> irq < 0
>
> Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
> ---
> drivers/spi/spi-mpc52xx-psc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Your subject lines are still incorrect :(
next prev parent reply other threads:[~2023-08-05 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 20:07 [PATCH v2] fixes warning coolrrsh
2023-08-04 20:07 ` coolrrsh
2023-08-05 6:22 ` Greg KH [this message]
2023-08-05 15:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080507-umbrella-automated-0db9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=coolrrsh@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox