From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A29C0015E for ; Sat, 5 Aug 2023 11:48:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbjHELsw (ORCPT ); Sat, 5 Aug 2023 07:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjHELst (ORCPT ); Sat, 5 Aug 2023 07:48:49 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BDF591720; Sat, 5 Aug 2023 04:48:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C5D0780A0; Sat, 5 Aug 2023 11:48:47 +0000 (UTC) Date: Sat, 5 Aug 2023 14:48:46 +0300 From: Tony Lindgren To: Guenter Roeck Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2 1/1] serial: core: Fix serial_base_match() after fixing controller port name Message-ID: <20230805114846.GK14799@atomide.com> References: <20230803071034.25571-1-tony@atomide.com> <0e1bc27d-dc84-473d-bfdf-db0743c5d64a@roeck-us.net> <20230805044910.GJ14799@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Guenter Roeck [230805 10:50]: > On 8/4/23 21:49, Tony Lindgren wrote: > > * Guenter Roeck [230804 21:42]: > > > kobject: kobject_add_internal failed for serial8250.0:0.0 with -EEXIST, don't try to register things with the same name in the same directory. > > > serial8250 serial8250.0: unable to register port at index 1 (IO2f8 MEM0 IRQ3): -17 > > > sysfs: cannot create duplicate filename '/devices/platform/serial8250.0/serial8250.0:0/serial8250.0:0.0' > > > > The issue above should be fixed with commit: > > > > bbb4abb1bcfb ("serial: 8250: Reinit port_id when adding back serial8250_isa_devs") > > > > No. I tested the tip of tty-linus (v6.5-rc4-9-gdfe2aeb226fd) which includes > above commit, but still see the problem. sparc images also still stall after > the "cannot create duplicate filename" message. > I bisected the sparc problem - it also bisects to commit d962de6ae51f. > > The problem affects all mips boot tests, all sparc boot tests, as well as > arm sx1, ppc bamboo and sam460ex emulations. As far as I can see, those > call serial8250_register_8250_port() without calling serial8250_setup_port() > and thus don't set port_id. I am only testing a few of those, so I strongly > suspect that all similar callers of serial8250_register_8250_port() are > affected (i.e., almost all of them) if they register more than one serial port. OK thanks for explaining. So we need to initialize port->port_id for the multi-port instances to avoid being stuck with the port->line index. I'll take a look. I wonder if we should just revert d962de6ae51f for now. It needs to be tested to see if something else also needs reverting though. Regards, Tony