public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Zhangjin Wu <falcon@tinylab.org>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, tanyuan@tinylab.org,
	thomas@t-8ch.de
Subject: Re: [PATCH v6 8/8] selftests/nolibc: customize CROSS_COMPILE for 32/64-bit powerpc
Date: Sat, 5 Aug 2023 22:48:45 +0200	[thread overview]
Message-ID: <20230805204845.GA7300@1wt.eu> (raw)
In-Reply-To: <2c3ac4542621ddc4b2cab006ae8e3a7b709921f1.1691259983.git.falcon@tinylab.org>

On Sun, Aug 06, 2023 at 02:47:09AM +0800, Zhangjin Wu wrote:
> The little-endian powerpc64le compilers provided by Ubuntu and Fedora
> are able to compile big endian kernel and big endian nolibc-test [1].

FWIW I'm wondering why focusing on these ones which have a different
naming from the other ones, when I think that most users rely on the
ones maintained by Arnd there:

   https://mirrors.edge.kernel.org/pub/tools/crosstool/

Yours is called powerpc64le while the one above is "powerpc64", it
requires to make an exception for this one, I find this a bit odd.

If someone wants to use their distro's cross toolchain, that's fine,
but I think that it will depend on distros anyway and some may not
even be provided (like loongarch) so I think it would make more sense
to adopt the canonical naming from Arnd's toolchains above.

It's not critical, but as you showed below, it makes building for ppc
a little bit cumbersome: those "export" lines could be dropped when
using the default names, and that's what we should document as the
recommended way to test:

> For example, it is able to build 64-bit nolibc-test with the big endian
> powerpc64-linux-gcc crosstool from [2]:
> 
>     $ wget -c https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.1.0/x86_64-gcc-13.1.0-nolibc-powerpc64-linux.tar.xz
>     $ tar xvf x86_64-gcc-13.1.0-nolibc-powerpc64-linux.tar.xz
>     $ export PATH=$PWD/gcc-13.1.0-nolibc/powerpc64-linux/bin/:$PATH
> 
>     $ export CROSS_COMPILE_ppc=powerpc64-linux-
>     $ export CROSS_COMPILE_ppc64=powerpc64-linux-
>     $ export CROSS_COMPILE_ppc64le=powerpc64-linux-
>     $ for arch in ppc ppc64 ppc64le; do \
>         make run-user XARCH=$arch | grep "status: "; \
>       done

Any opinion on this ?

Thanks,
Willy

  reply	other threads:[~2023-08-05 20:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-05 18:38 [PATCH v6 0/8] tools/nolibc: add 32/64-bit powerpc support Zhangjin Wu
2023-08-05 18:39 ` [PATCH v6 1/8] tools/nolibc: add support for powerpc Zhangjin Wu
2023-08-05 18:40 ` [PATCH v6 2/8] tools/nolibc: add support for powerpc64 Zhangjin Wu
2023-08-05 18:41 ` [PATCH v6 3/8] selftests/nolibc: add XARCH and ARCH mapping support Zhangjin Wu
2023-08-05 18:42 ` [PATCH v6 4/8] selftests/nolibc: add test support for ppc Zhangjin Wu
2023-08-05 18:43 ` [PATCH v6 5/8] selftests/nolibc: add test support for ppc64le Zhangjin Wu
2023-08-05 18:44 ` [PATCH v6 6/8] selftests/nolibc: add test support for ppc64 Zhangjin Wu
2023-08-05 18:46 ` [PATCH v6 7/8] selftests/nolibc: allow customize CROSS_COMPILE by architecture Zhangjin Wu
2023-08-06  8:17   ` Willy Tarreau
2023-08-06  9:39     ` Zhangjin Wu
2023-08-06 10:04       ` Willy Tarreau
2023-08-06 10:16         ` Zhangjin Wu
2023-08-05 18:47 ` [PATCH v6 8/8] selftests/nolibc: customize CROSS_COMPILE for 32/64-bit powerpc Zhangjin Wu
2023-08-05 20:48   ` Willy Tarreau [this message]
2023-08-06  3:11     ` Zhangjin Wu
2023-08-06  3:18       ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230805204845.GA7300@1wt.eu \
    --to=w@1wt.eu \
    --cc=arnd@arndb.de \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=tanyuan@tinylab.org \
    --cc=thomas@t-8ch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox