From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51402C0015E for ; Sun, 6 Aug 2023 06:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbjHFGXg (ORCPT ); Sun, 6 Aug 2023 02:23:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjHFGXd (ORCPT ); Sun, 6 Aug 2023 02:23:33 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 63CC81FD3; Sat, 5 Aug 2023 23:23:32 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id CBCDA80A0; Sun, 6 Aug 2023 06:23:31 +0000 (UTC) Date: Sun, 6 Aug 2023 09:23:30 +0300 From: Tony Lindgren To: Guenter Roeck Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2 1/1] serial: core: Fix serial_base_match() after fixing controller port name Message-ID: <20230806062330.GM14799@atomide.com> References: <20230803071034.25571-1-tony@atomide.com> <0e1bc27d-dc84-473d-bfdf-db0743c5d64a@roeck-us.net> <20230805044910.GJ14799@atomide.com> <20230805114846.GK14799@atomide.com> <095e0120-ba81-64e7-e5d0-c042fb64978f@roeck-us.net> <20230806043357.GL14799@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230806043357.GL14799@atomide.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [230806 07:34]: > To me it seems we can't use port->port_id until multiport drivers > initialize it, or set port->port_id automatically with ida_alloc(). > > Meanwhile, we can just change back to using port->line assuming that > fixes the issue for your tests. This means the port names are broken > like we had in -rc1 but that's a cosmetic issue for now. Sent it with a proper patch description [0]. Regards, Tony [0] https://lore.kernel.org/linux-serial/20230806062052.47737-1-tony@atomide.com/T/#u