* [PATCH 2/3] s390: replace #include <asm/export.h> with #include <linux/export.h>
2023-08-06 15:16 [PATCH 1/3] s390: remove unneeded #include <asm/export.h> Masahiro Yamada
@ 2023-08-06 15:16 ` Masahiro Yamada
2023-08-06 15:16 ` [PATCH 3/3] s390: remove <asm/export.h> Masahiro Yamada
2023-08-07 8:51 ` [PATCH 1/3] s390: remove unneeded #include <asm/export.h> Heiko Carstens
2 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2023-08-06 15:16 UTC (permalink / raw)
To: Heiko Carstens, Vasily Gorbik, Alexander Gordeev, linux-s390
Cc: Christian Borntraeger, Sven Schnelle, linux-kernel, linux-arch,
Masahiro Yamada
Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
deprecated <asm/export.h>, which is now a wrapper of <linux/export.h>.
Replace #include <asm/export.h> with #include <linux/export.h>.
After all the <asm/export.h> lines are converted, <asm/export.h> and
<asm-generic/export.h> will be removed.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/s390/kernel/entry.S | 2 +-
arch/s390/lib/mem.S | 2 +-
arch/s390/lib/tishift.S | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/s390/kernel/entry.S b/arch/s390/kernel/entry.S
index a660f4b6d654..49a11f6dd7ae 100644
--- a/arch/s390/kernel/entry.S
+++ b/arch/s390/kernel/entry.S
@@ -8,6 +8,7 @@
* Denis Joseph Barrow (djbarrow@de.ibm.com,barrow_dj@yahoo.com),
*/
+#include <linux/export.h>
#include <linux/init.h>
#include <linux/linkage.h>
#include <asm/asm-extable.h>
@@ -26,7 +27,6 @@
#include <asm/vx-insn.h>
#include <asm/setup.h>
#include <asm/nmi.h>
-#include <asm/export.h>
#include <asm/nospec-insn.h>
_LPP_OFFSET = __LC_LPP
diff --git a/arch/s390/lib/mem.S b/arch/s390/lib/mem.S
index 5a9a55de2e10..08f60a42b9a6 100644
--- a/arch/s390/lib/mem.S
+++ b/arch/s390/lib/mem.S
@@ -5,8 +5,8 @@
* Copyright IBM Corp. 2012
*/
+#include <linux/export.h>
#include <linux/linkage.h>
-#include <asm/export.h>
#include <asm/nospec-insn.h>
GEN_BR_THUNK %r14
diff --git a/arch/s390/lib/tishift.S b/arch/s390/lib/tishift.S
index de33cf02cfd2..96214f51f49b 100644
--- a/arch/s390/lib/tishift.S
+++ b/arch/s390/lib/tishift.S
@@ -1,8 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0 */
+#include <linux/export.h>
#include <linux/linkage.h>
#include <asm/nospec-insn.h>
-#include <asm/export.h>
.section .noinstr.text, "ax"
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] s390: remove <asm/export.h>
2023-08-06 15:16 [PATCH 1/3] s390: remove unneeded #include <asm/export.h> Masahiro Yamada
2023-08-06 15:16 ` [PATCH 2/3] s390: replace #include <asm/export.h> with #include <linux/export.h> Masahiro Yamada
@ 2023-08-06 15:16 ` Masahiro Yamada
2023-08-07 8:51 ` [PATCH 1/3] s390: remove unneeded #include <asm/export.h> Heiko Carstens
2 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2023-08-06 15:16 UTC (permalink / raw)
To: Heiko Carstens, Vasily Gorbik, Alexander Gordeev, linux-s390
Cc: Christian Borntraeger, Sven Schnelle, linux-kernel, linux-arch,
Masahiro Yamada
All *.S files under arch/s390/ have been converted to include
<linux/export.h> instead of <asm/export.h>.
Remove <asm/export.h>.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/s390/include/asm/Kbuild | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/s390/include/asm/Kbuild b/arch/s390/include/asm/Kbuild
index 1a18d7b82f86..4b904110d27c 100644
--- a/arch/s390/include/asm/Kbuild
+++ b/arch/s390/include/asm/Kbuild
@@ -5,6 +5,5 @@ generated-y += syscall_table.h
generated-y += unistd_nr.h
generic-y += asm-offsets.h
-generic-y += export.h
generic-y += kvm_types.h
generic-y += mcs_spinlock.h
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] s390: remove unneeded #include <asm/export.h>
2023-08-06 15:16 [PATCH 1/3] s390: remove unneeded #include <asm/export.h> Masahiro Yamada
2023-08-06 15:16 ` [PATCH 2/3] s390: replace #include <asm/export.h> with #include <linux/export.h> Masahiro Yamada
2023-08-06 15:16 ` [PATCH 3/3] s390: remove <asm/export.h> Masahiro Yamada
@ 2023-08-07 8:51 ` Heiko Carstens
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Carstens @ 2023-08-07 8:51 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Vasily Gorbik, Alexander Gordeev, linux-s390,
Christian Borntraeger, Sven Schnelle, linux-kernel, linux-arch
On Mon, Aug 07, 2023 at 12:16:38AM +0900, Masahiro Yamada wrote:
> There is no EXPORT_SYMBOL line there, hence #include <asm/export.h>
> is unneeded.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/s390/kernel/mcount.S | 2 --
> 1 file changed, 2 deletions(-)
All three patches applied. Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread