* [PATCH] reset: npcm: remove unneeded call to platform_set_drvdata()
@ 2023-08-07 10:56 Andrei Coardos
2023-08-08 13:47 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Coardos @ 2023-08-07 10:56 UTC (permalink / raw)
To: linux-kernel, openbmc
Cc: p.zabel, benjaminfair, yuenn, venture, tali.perry1, tmaimon77,
avifishman70, Andrei Coardos, Alexandru Ardelean
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/reset/reset-npcm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c
index f2333506b0a6..f6c4f854f2be 100644
--- a/drivers/reset/reset-npcm.c
+++ b/drivers/reset/reset-npcm.c
@@ -394,8 +394,6 @@ static int npcm_rc_probe(struct platform_device *pdev)
rc->rcdev.of_reset_n_cells = 2;
rc->rcdev.of_xlate = npcm_reset_xlate;
- platform_set_drvdata(pdev, rc);
-
ret = devm_reset_controller_register(&pdev->dev, &rc->rcdev);
if (ret) {
dev_err(&pdev->dev, "unable to register device\n");
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: npcm: remove unneeded call to platform_set_drvdata()
2023-08-07 10:56 [PATCH] reset: npcm: remove unneeded call to platform_set_drvdata() Andrei Coardos
@ 2023-08-08 13:47 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2023-08-08 13:47 UTC (permalink / raw)
To: Andrei Coardos, linux-kernel, openbmc
Cc: benjaminfair, yuenn, venture, tali.perry1, tmaimon77,
avifishman70, Alexandru Ardelean
On Mo, 2023-08-07 at 13:56 +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Thank you, applied to reset/next.
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-08 19:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07 10:56 [PATCH] reset: npcm: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-08 13:47 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox