From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1279C001B0 for ; Mon, 7 Aug 2023 11:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232644AbjHGLzM (ORCPT ); Mon, 7 Aug 2023 07:55:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbjHGLzK (ORCPT ); Mon, 7 Aug 2023 07:55:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E02083; Mon, 7 Aug 2023 04:55:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 63333618FB; Mon, 7 Aug 2023 11:55:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29F76C433C8; Mon, 7 Aug 2023 11:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691409307; bh=R/epzjP4MVztL6PEKysek/qZr/5qEjO+L1hh2sVtNkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FYkZSXK438kVYpG/FfDQDXVWZYMWtJMrr9KwB6PJW4J+YmLIa2fk0wCMulUqhO9zp ix0aut8KRwYPunKf7198c6rEXJCR+pf///fpbovSM7xfEohg1MislFmv1G87kzlf2X mxbYMX8LKi5rQ4FR/+m0oWM5gNVYMxS5U4hjUmwAP6cWp2Vxn7gsfO+Rm2udz/YQRf 8sQ2mCC5Qjfj1DITaA9qBxImpEPtCGiTUeCoD0nFe20okcNVMTYkhcnb6qBqEkR8hf nXdzGOsib5BG2JkNGhMhh1ZvNcKDZIbXZM/3pqoqJwlgk7EIs+nQRt9uIbUEtEnHVz mruoq1GaQNhtw== Date: Mon, 7 Aug 2023 13:55:03 +0200 From: Andi Shyti To: "Liao, Chang" Cc: florian.fainelli@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com, linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 8/9] i2c: imx-lpi2c: Use dev_err_probe in probe function Message-ID: <20230807115503.u7qrtmt23vzosehr@intel.intel> References: <20230802095737.3957587-1-liaochang1@huawei.com> <20230802095737.3957587-9-liaochang1@huawei.com> <20230804221644.cqmoin6u22mxvouk@intel.intel> <758b882e-31a5-1f73-7fd2-945a8a2e9558@huawei.com> <20230807081725.fmjvdp3gxjs2ijee@intel.intel> <042c6eb7-cf31-79e1-51c7-c229e2582c0c@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <042c6eb7-cf31-79e1-51c7-c229e2582c0c@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 07, 2023 at 06:44:23PM +0800, Liao, Chang wrote: > Hi, Andi > > 在 2023/8/7 16:17, Andi Shyti 写道: > > On Mon, Aug 07, 2023 at 10:13:30AM +0800, Liao, Chang wrote: > >> Hi, Andi > >> > >> 在 2023/8/5 6:16, Andi Shyti 写道: > >>> On Wed, Aug 02, 2023 at 05:57:36PM +0800, Liao Chang wrote: > >>>> Use the dev_err_probe function instead of dev_err in the probe function > >>>> so that the printed messge includes the return value and also handles > >>>> -EPROBE_DEFER nicely. > >>>> > >>>> Signed-off-by: Liao Chang > >>>> --- > >>>> drivers/i2c/busses/i2c-imx-lpi2c.c | 12 ++++-------- > >>>> 1 file changed, 4 insertions(+), 8 deletions(-) > >>>> > >>>> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c > >>>> index c3287c887c6f..bfa788b3775b 100644 > >>>> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > >>>> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > >>>> @@ -569,10 +569,8 @@ static int lpi2c_imx_probe(struct platform_device *pdev) > >>>> sizeof(lpi2c_imx->adapter.name)); > >>>> > >>>> ret = devm_clk_bulk_get_all(&pdev->dev, &lpi2c_imx->clks); > >>>> - if (ret < 0) { > >>>> - dev_err(&pdev->dev, "can't get I2C peripheral clock, ret=%d\n", ret); > >>>> - return ret; > >>>> - } > >>>> + if (ret < 0) > >>>> + return dev_err_probe(&pdev->dev, ret, "can't get I2C peripheral clock\n"); > >>> > >>> you cut on this because the line was going over 100 characters? :) > >>> > >>> In theory you shouldn't change the print message when doing such > >>> changes and you can still split it as: > >>> > >>> return dev_err_probe(&pdev->dev, ret, > >>> "can't get I2C peripheral clock, ret=%d\n", > >>> ret); > >>> > >>> and you're even within the 80 characters. > >> > >> Since dev_err_probe always print the second parameter that happens to be the return value, > >> I remove the "ret=%d" from the original message to avoid a redundant error message. > >> > >> So is it better to keep the original message unchanged, even though dev_err_probe also prints > >> the return error value? Or is it better to make this change so that all error messages printed > >> in the probe function include the return value in a consistent style? > > > > yes, you are right! Then please ignore this comment, but... > > > >>> ret = devm_request_irq(&pdev->dev, irq, lpi2c_imx_isr, 0, > >>> pdev->name, lpi2c_imx); > >>> - if (ret) { > >>> - dev_err(&pdev->dev, "can't claim irq %d\n", irq); > >>> - return ret; > >>> - } > >>> + if (ret) > >>> + return dev_err_probe(&pdev->dev, ret, "can't claim irq %d\n", irq); > > > > please make it coherent to this second part, as well, where the > > error number is printed. > > Do you mean to convert it to the following? > > if (ret) > return dev_err_probe(&pdev->dev, ret, "can't claim irq\n"); > > I understand that the style of error message printed by dev_err_probe is like > "error [ERRNO]: [customized message]", the [ERRNO] comes from 2nd parameter, > [customized message] comes from 3rd paramter, if the original [customized message]it > also print ERRNO, i intend to remove it in this patch, otherwise, I will just keep it. > In the above code, [customized message] intend to print irq but return value, so it is > better to keep the original message, right? sorry... I just got confused and read wrong the code. Please ignore my comments on this patch, you are right here. Feel free to add. Reviewed-by: Andi Shyti Andi