From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5851AC04A6A for ; Mon, 7 Aug 2023 17:44:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbjHGRo5 (ORCPT ); Mon, 7 Aug 2023 13:44:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbjHGRoy (ORCPT ); Mon, 7 Aug 2023 13:44:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10A6EE74; Mon, 7 Aug 2023 10:44:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3A836207C; Mon, 7 Aug 2023 17:44:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87437C433C8; Mon, 7 Aug 2023 17:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691430292; bh=yzistt618Ih1kJYESJPMNcNELXH2a97Q4rPHaNy7qk8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y4Gi0zIzLL7fnmP+pj1s2gfih+iJhtPe4VHRpj/czfpKmjSeW239LJWuAMXtc7diC R+dZcb3XuBNoX0g1nt9ZTGe8IfdCAYD1tBdtxIFjtGFLkFL2qfmeabmYkfSLoEwKcg tVCyNKIgbckdVK6WQeEz6atRByVDtpmmw6EJ9Wzs= Date: Mon, 7 Aug 2023 19:44:49 +0200 From: Greg Kroah-Hartman To: Souradeep Chowdhury Cc: Trilok Soni , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Alex Elder , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak Subject: Re: [PATCH V25 0/3] misc: Add driver support for Data Capture and Compare unit(DCC) Message-ID: <2023080753-decode-outgoing-b6c6@gregkh> References: <774b688f-0324-9097-6504-58d15a3e6afb@quicinc.com> <2023080438-reacquire-obsessed-3e81@gregkh> <2023080408-zoom-defraud-1ae8@gregkh> <75c25eac-e92c-5ca2-4ef6-06ee89584ce6@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75c25eac-e92c-5ca2-4ef6-06ee89584ce6@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 07, 2023 at 11:03:45PM +0530, Souradeep Chowdhury wrote: > > > On 8/4/2023 7:19 PM, Greg Kroah-Hartman wrote: > > On Fri, Aug 04, 2023 at 03:47:26PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Aug 03, 2023 at 07:35:18AM -0700, Trilok Soni wrote: > > > > On 8/3/2023 12:06 AM, Souradeep Chowdhury wrote: > > > > > > > > > > > > > > > On 6/28/2023 3:53 PM, Souradeep Chowdhury wrote: > > > > > > > > ... > > > > > > > > > > > > > > > > https://git.codelinaro.org/clo/le/platform/vendor/qcom-opensource/tools/-/tree/opensource-tools.lnx.1.0.r176-rel/dcc_parser > > > > > > > > > > > > Changes in v25 > > > > > > > > > > > > * Updated the documentation of the structure dcc_config_entry as per > > > > > > the comments in V23 > > > > > > * Updated the documentation of the dcc Kconfig definition as per > > > > > > comment in V24 > > > > > > * Used u64 where applicable > > > > > > * Removed the mutex locks where it is not needed > > > > > > * Removed the use of unlikely keyword > > > > > > * Renamed "nr_link_list" to "max_link_list" > > > > > > > > > > > > Souradeep Chowdhury (3): > > > > > >    dt-bindings: misc: qcom,dcc: Add the dtschema > > > > > >    misc: dcc: Add driver support for Data Capture and Compare unit(DCC) > > > > > >    MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver > > > > > >      support > > > > > > > > > > > >   Documentation/ABI/testing/debugfs-driver-dcc  |   10 +- > > > > > >   .../devicetree/bindings/misc/qcom,dcc.yaml    |   44 + > > > > > >   MAINTAINERS                                   |    8 + > > > > > >   drivers/misc/Kconfig                          |    8 + > > > > > >   drivers/misc/Makefile                         |    1 + > > > > > >   drivers/misc/qcom-dcc.c                       | 1312 +++++++++++++++++ > > > > > >   6 files changed, 1378 insertions(+), 5 deletions(-) > > > > > >   create mode 100644 Documentation/devicetree/bindings/misc/qcom,dcc.yaml > > > > > >   create mode 100644 drivers/misc/qcom-dcc.c > > > > > > > > > > Gentle Ping > > > > > > > > Thank you for the reminder Souradeep. Greg and others, please see if we need > > > > any changes here or it can be picked up? > > > > > > It would help if the code would actually build: > > > > > > drivers/misc/qcom-dcc.c: In function ‘ready_read’: > > > drivers/misc/qcom-dcc.c:853:13: error: unused variable ‘ret’ [-Werror=unused-variable] > > > 853 | int ret = 0; > > > | ^~~ > > > > > > {sigh} > > > > > > How in the world was this ever tested? > > > > Ok, next time I want to see some QCOM engineers to sign off on this that > > it was actually tested and they can back it up that this is ready to be > > merged. When the code doesn't even build, that is a huge red flag that > > this whole thing is being rushed as it obviously was never tested in the > > form that was submitted for inclusion. > > > > You all know better than this. > > My apologies on missing out on this, it is a W=1 level compilation warning > that got suppressed on a normal kernel build. No, not at all, it showed up on my "normal kernel build", I do not have "W=1" set at all. If you did a simple "make allmodconfig" I am pretty sure it would have tripped this. How exactly was this tested? thanks, greg k-h