* [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_MATCH condition
@ 2023-08-08 9:48 Peter Ujfalusi
2023-08-10 15:13 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2023-08-08 9:48 UTC (permalink / raw)
To: peterhuewe, jarkko
Cc: jgg, linux-integrity, linux-kernel, l.sanfilippo, peter.ujfalusi,
jsnitsel, pmenzel
The patch which made it to the kernel somehow changed the
match condition from
DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
to
DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL")
Revert back to the correct match condition to disable the
interrupt mode on the board.
Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
Fixes: edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
---
drivers/char/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index ac4daaf294a3..3c0f68b9e44f 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
.ident = "UPX-TGL",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
- DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
},
},
{}
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_MATCH condition
2023-08-08 9:48 [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_MATCH condition Peter Ujfalusi
@ 2023-08-10 15:13 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2023-08-10 15:13 UTC (permalink / raw)
To: Peter Ujfalusi, peterhuewe
Cc: jgg, linux-integrity, linux-kernel, l.sanfilippo, jsnitsel,
pmenzel
On Tue Aug 8, 2023 at 12:48 PM EEST, Peter Ujfalusi wrote:
> The patch which made it to the kernel somehow changed the
> match condition from
> DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
> to
> DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL")
>
> Revert back to the correct match condition to disable the
> interrupt mode on the board.
>
> Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
> Fixes: edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index ac4daaf294a3..3c0f68b9e44f 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> .ident = "UPX-TGL",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
> },
> },
> {}
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-10 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 9:48 [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_MATCH condition Peter Ujfalusi
2023-08-10 15:13 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox