Re: [PATCH v2 10/11] PCI/VGA: Tidy up the code and comment format

Ilpo Järvinen
2023-08-09T14:18:50Z

[-- Attachment #1: Type: text/plain, Size: 3349 bytes --]

On Wed, 9 Aug 2023, Sui Jingfeng wrote:

> From: Sui Jingfeng <suijingfeng@loongson.cn>
>
> This patch replaces the leading space with a tab and removes the double
> blank line and fix various typos, no functional change.
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
> drivers/pci/vgaarb.c | 90 ++++++++++++++++++++++++------------------
> include/linux/vgaarb.h | 4 +-
> 2 files changed, 53 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
> index 9f5cf6a6e3a2..a2f6e0e6b634 100644
> --- a/drivers/pci/vgaarb.c
> +++ b/drivers/pci/vgaarb.c
> @@ -30,14 +30,13 @@
> #include <linux/vt.h>
> #include <linux/console.h>
> #include <linux/acpi.h>
> -
> #include <linux/uaccess.h>
> -
> #include <linux/vgaarb.h>
>
> static void vga_arbiter_notify_clients(void);
> +
> /*
> - * We keep a list of all vga devices in the system to speed
> + * We keep a list of all VGA devices in the system to speed
> * up the various operations of the arbiter
> */
> struct vga_device {
> @@ -61,7 +60,6 @@ static bool vga_arbiter_used;
> static DEFINE_SPINLOCK(vga_lock);
> static DECLARE_WAIT_QUEUE_HEAD(vga_wait_queue);
>
> -
> static const char *vga_iostate_to_str(unsigned int iostate)
> {
> /* Ignore VGA_RSRC_IO and VGA_RSRC_MEM */
> @@ -195,14 +193,16 @@ int vga_remove_vgacon(struct pci_dev *pdev)
> #endif
> EXPORT_SYMBOL(vga_remove_vgacon);
>
> -/* If we don't ever use VGA arb we should avoid
> - turning off anything anywhere due to old X servers getting
> - confused about the boot device not being VGA */
> +/*
> + * If we don't ever use vgaarb, we should avoid turning off anything anywhere.
> + * Due to old X servers getting confused about the boot device not being VGA.
> + */
> static void vga_check_first_use(void)
> {
> - /* we should inform all GPUs in the system that
> - * VGA arb has occurred and to try and disable resources
> - * if they can */
> + /*
> + * We should inform all GPUs in the system that
> + * vgaarb has occurred and to try and disable resources if they can
> + */
> if (!vga_arbiter_used) {
> vga_arbiter_used = true;
> vga_arbiter_notify_clients();
> @@ -218,7 +218,8 @@ static struct vga_device *__vga_tryget(struct vga_device *vgadev,
> unsigned int pci_bits;
> u32 flags = 0;
>
> - /* Account for "normal" resources to lock. If we decode the legacy,
> + /*
> + * Account for "normal" resources to lock. If we decode the legacy,
> * counterpart, we need to request it as well
> */
> if ((rsrc & VGA_RSRC_NORMAL_IO) &&
> @@ -238,7 +239,8 @@ static struct vga_device *__vga_tryget(struct vga_device *vgadev,
> if (wants == 0)
> goto lock_them;
>
> - /* We don't need to request a legacy resource, we just enable
> + /*
> + * We don't need to request a legacy resource, we just enable
> * appropriate decoding and go
> */
> legacy_wants = wants & VGA_RSRC_LEGACY_MASK;
> @@ -254,7 +256,8 @@ static struct vga_device *__vga_tryget(struct vga_device *vgadev,
> if (vgadev == conflict)
> continue;
>
> - /* We have a possible conflict. before we go further, we must
> + /*
> + * We have a possible conflict. before we go further, we must

Before

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.