Re: [PATCH v2 06/11] PCI/VGA: Fix two typos in the comments of pci_notify()

Ilpo Järvinen
2023-08-09T14:12:43Z

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Wed, 9 Aug 2023, Sui Jingfeng wrote:

> From: Sui Jingfeng <suijingfeng@loongson.cn>
>
> 1) s/intereted/interested
> 2) s/hotplugable/hot-pluggable
>
> While at it, convert the comments to the conventional multi-line style,
> and rewrap to fill 78 columns.
>
> Fixes: deb2d2ecd43d ("PCI/GPU: implement VGA arbitration on Linux")
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
> drivers/pci/vgaarb.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
> index 6883067a802a..811510253553 100644
> --- a/drivers/pci/vgaarb.c
> +++ b/drivers/pci/vgaarb.c
> @@ -1535,9 +1535,11 @@ static int pci_notify(struct notifier_block *nb, unsigned long action,
> if (!pci_dev_is_vga(pdev))
> return 0;
>
> - /* For now we're only intereted in devices added and removed. I didn't
> - * test this thing here, so someone needs to double check for the
> - * cases of hotplugable vga cards. */
> + /*
> + * For now, we're only interested in devices added and removed.
> + * I didn't test this thing here, so someone needs to double check
> + * for the cases of hot-pluggable VGA cards.
> + */
> if (action == BUS_NOTIFY_ADD_DEVICE)
> notify = vga_arbiter_add_pci_device(pdev);
> else if (action == BUS_NOTIFY_DEL_DEVICE)

Don't use Fixes tag for comment changes. After removing it, feel free to
add:

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.