From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huaweicloud.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
John Ogness <john.ogness@linutronix.de>,
linux-kernel@vger.kernel.org,
Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH 2/2] hexdump: add a new dump prefix DUMP_PREFIX_ADDRESS_LOW16
Date: Wed, 9 Aug 2023 13:10:57 +0900 [thread overview]
Message-ID: <20230809041057.GB681074@google.com> (raw)
In-Reply-To: <319df959-5be9-66c5-680f-4a5ae59019b9@huaweicloud.com>
On (23/08/08 15:52), Leizhen (ThunderTown) wrote:
> >> I find the "before" much easier to read than the "after".
>
> I added the boot option no_hash_pointers, so "before" can print the
> address. Otherwise, just print the 32-bit hash value, as shown below:
> [ 14.872153] dump memory at sp=ffff800080903aa0:
This line is not guaranteed to be printed. If you get
"** N printk messages dropped **" instead then the
ADDRESS_LOW16 math doesn't work.
> Actually, I added DUMP_PREFIX_ADDRESS_LOW16 because of another scene:
> slab kmalloc-512 start ffff3b3c0094e800 pointer offset 168 size 512
> e888: 00400000 00000000 000f7704 00000000
> e898: 000f7704 00000000 12345678 00000000
> e8a8: 00000000 00000000 00000000 00000000
> e8b8: 9abcdef0 00000000 00507dd0 00000000
>
> Here, the start address ffff3b3c0094e800 of slab object is printed by %px,
> the address of the error data is at p=ffff3b3c0094e8a8 = ffff3b3c0094e800 + offset 168.
> To locate the problem, dump up to 64 bytes centered on 'p'.
next prev parent reply other threads:[~2023-08-09 4:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 7:21 [PATCH 0/2] hexdump: minimize the output width of address and offset thunder.leizhen
2023-08-05 7:21 ` [PATCH 1/2] hexdump: minimize the output width of the offset thunder.leizhen
2023-08-07 22:37 ` Randy Dunlap
2023-08-08 1:10 ` Leizhen (ThunderTown)
2023-08-08 2:42 ` Randy Dunlap
2023-08-08 2:54 ` Leizhen (ThunderTown)
2023-08-05 7:21 ` [PATCH 2/2] hexdump: add a new dump prefix DUMP_PREFIX_ADDRESS_LOW16 thunder.leizhen
2023-08-07 22:37 ` Randy Dunlap
2023-08-08 1:14 ` Steven Rostedt
2023-08-08 1:51 ` Leizhen (ThunderTown)
[not found] ` <319df959-5be9-66c5-680f-4a5ae59019b9@huaweicloud.com>
2023-08-09 4:10 ` Sergey Senozhatsky [this message]
2023-08-09 7:05 ` Leizhen (ThunderTown)
2023-08-11 7:31 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809041057.GB681074@google.com \
--to=senozhatsky@chromium.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=thunder.leizhen@huawei.com \
--cc=thunder.leizhen@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox