From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE13C0015E for ; Wed, 9 Aug 2023 07:28:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230387AbjHIH2U (ORCPT ); Wed, 9 Aug 2023 03:28:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231708AbjHIH2A (ORCPT ); Wed, 9 Aug 2023 03:28:00 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A51FF271C; Wed, 9 Aug 2023 00:27:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1819D8105; Wed, 9 Aug 2023 07:27:22 +0000 (UTC) Date: Wed, 9 Aug 2023 10:27:20 +0300 From: Tony Lindgren To: Nishanth Menon Cc: Dhruva Gole , linux-omap@vger.kernel.org, Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Keerthy , Kevin Hilman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] bus: ti-sysc: Fix build warning for 64-bit build Message-ID: <20230809072720.GC11676@atomide.com> References: <20230804103859.57458-1-tony@atomide.com> <20230805051753.vpwhg52zttpbbntx@dhruva> <20230805172325.4vjb4lb3vtu3dgfe@commodity> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230805172325.4vjb4lb3vtu3dgfe@commodity> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nishanth Menon [230805 17:23]: > On 10:47-20230805, Dhruva Gole wrote: > > On Aug 04, 2023 at 13:38:57 +0300, Tony Lindgren wrote: > > > match = soc_device_match(sysc_soc_match); > > > if (match && match->data) > > > - sysc_soc->soc = (int)match->data; > > > + sysc_soc->soc = (unsigned long)match->data; > > > > Reviewed-by: Dhruva Gole > > Dumb q: is'nt this an enum? Is it better to cast it as (enum > sysc_soc)match->data ? Good idea, will update. Regards, Tony