From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36968C001DE for ; Wed, 9 Aug 2023 12:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbjHIMUY (ORCPT ); Wed, 9 Aug 2023 08:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231804AbjHIMUW (ORCPT ); Wed, 9 Aug 2023 08:20:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ACEE1BF0 for ; Wed, 9 Aug 2023 05:20:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A46A0636C7 for ; Wed, 9 Aug 2023 12:20:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADD23C433C8; Wed, 9 Aug 2023 12:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691583621; bh=qkd5uVTEEPS8zjHnXRACa23VVQLyxESeRtfjdn1FCf8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vVOMtPVAXbbpGMJ9HCdTTuSg6N7NfPF3/Tv5UonXmWUx7Zzr8aLJRzS5bb4bg1ia2 deq3rrAYlGfAuMtR2Jk8TVs66tK82eSlnTQ9Qe6WDZumwcB3oT9vvTukdgns8kAtjz 80YwCm9N7uazPhXe+qoJ8lC7yHMwcvxL4KXm46Pk= Date: Wed, 9 Aug 2023 14:20:18 +0200 From: Greg KH To: Pavan Bobba Cc: Forest Bond , Michael Straube , Philipp Hortmann , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vt6655: replace camel case by snake case Message-ID: <2023080918-opulently-eclipse-7555@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 05, 2023 at 02:29:04PM +0530, Pavan Bobba wrote: > Replace array name of camel case by snake case. Issue found > by checkpatch > > Signed-off-by: Pavan Bobba > --- > v1 -> v2: 1.character '_' added in the array name "byvt3253b0_rfmde" > 2. typo in the subject line "small case" corrected with the > proper word "snake case" > > drivers/staging/vt6655/baseband.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c > index 0e135af8316b..8b913c64845c 100644 > --- a/drivers/staging/vt6655/baseband.c > +++ b/drivers/staging/vt6655/baseband.c > @@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] = > }; > > #define CB_VT3253B0_INIT_FOR_RFMD 256 > -static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = { > +static const unsigned char byvt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = { The "by" here means "byte", a horrible naming scheme that was popular in the 1990's when C compilers would not check the types of variables. No need for that here, this should just be "vt3253b0_rfmd", right? thanks, greg k-h