From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BF8C41513 for ; Wed, 9 Aug 2023 22:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232704AbjHIWh3 (ORCPT ); Wed, 9 Aug 2023 18:37:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232845AbjHIWh2 (ORCPT ); Wed, 9 Aug 2023 18:37:28 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5990E7C; Wed, 9 Aug 2023 15:37:09 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 0075668AFE; Thu, 10 Aug 2023 00:37:04 +0200 (CEST) Date: Thu, 10 Aug 2023 00:37:03 +0200 From: hch To: Richard Weinberger Cc: hch , Stephan Wurm , linux-block , Miquel Raynal , Vignesh Raghavendra , linux-mtd , linux-kernel , Johannes Eigner Subject: Re: ubiblock: null pointer dereference using scatterlist in work_queue Message-ID: <20230809223703.GA10719@lst.de> References: <1293911429.1782934.1691445776353.JavaMail.zimbra@nod.at> <20230809135308.GA32214@lst.de> <20230809141542.GA32614@lst.de> <366198994.5052941.1691620484888.JavaMail.zimbra@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <366198994.5052941.1691620484888.JavaMail.zimbra@nod.at> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 12:34:44AM +0200, Richard Weinberger wrote: > Will do so! So far I managed to get UBIblock work with scsi_kmap_atomic_sg(). > Sadly now with kmap'ed memory a bounce buffer is needed since IO in UBI/MTD can sleep. > Is there a strong reason why scsi_kmap_atomic_sg() needs IRQs disabled? I don't think it needs irqs disabled. Also if you switch from the deprecated kmap_atomic to kmap_local first you can sleep and don't need bounce buffers.