public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mingzai Sun <szp2017@gmail.com>
Cc: forest@alittletooquiet.net, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: Change camel case variables to snake case
Date: Wed, 9 Aug 2023 14:21:51 +0200	[thread overview]
Message-ID: <2023080933-customs-undercoat-ba4d@gregkh> (raw)
In-Reply-To: <20230805035739.376502-1-szp2017@gmail.com>

On Sat, Aug 05, 2023 at 11:57:39AM +0800, Mingzai Sun wrote:
> Change camel case to snake case.
> Issue found by checkpatch.
> 
> Signed-off-by: Mingzai Sun <szp2017@gmail.com>
> ---
>  drivers/staging/vt6655/srom.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index ee5ca4db74dc..812964ab68c5 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -49,7 +49,7 @@
>   * Parameters:
>   *  In:
>   *      iobase          - I/O base address
> - *      byContntOffset  - address of EEPROM
> + *      by_contnt_offset  - address of EEPROM

Why did you keep the unneeded "by" prefix?

thanks,

greg k-h

  reply	other threads:[~2023-08-09 12:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-05  3:57 [PATCH] staging: vt6655: Change camel case variables to snake case Mingzai Sun
2023-08-09 12:21 ` Greg KH [this message]
2023-08-10 14:00   ` Leo Sun
2023-08-10 14:08 ` [PATCH v2] " Mingzai Sun
2023-08-11 20:36   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2023-08-12 15:17 [PATCH] " Mingzai Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023080933-customs-undercoat-ba4d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=szp2017@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox