From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D3A6C04A6A for ; Thu, 10 Aug 2023 19:02:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234569AbjHJTCy (ORCPT ); Thu, 10 Aug 2023 15:02:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236232AbjHJTCw (ORCPT ); Thu, 10 Aug 2023 15:02:52 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C10C1270A for ; Thu, 10 Aug 2023 12:02:51 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-268299d5d9fso753346a91.1 for ; Thu, 10 Aug 2023 12:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1691694171; x=1692298971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3lTerh5FxUXJzMDiiz5BJKMRyeOamjSvHt07GYvi4Kg=; b=f2pud/Zq/O2/8ChznoUK0UDXJDmdCRhJJEZv29JuSYcWMG/Grl9pkgwwczumeiLG94 rZLnyqSOCc4OO8NBBRh0J1E0SEOtNwucMp3uatZhTctkiVaoUJekdeX8xeZrVwEmNdUL hvSgiPnPVl11YFgixBmJB98oJQcTrJa7I0iCI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691694171; x=1692298971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3lTerh5FxUXJzMDiiz5BJKMRyeOamjSvHt07GYvi4Kg=; b=MeltLNLE9eKL0SUZOvDP+4Oeu0Udklh4veo/MDZvncy0+teEDmApiTuTr6uP8a/c8r 9EFtnAw8dulUC7RlMxEOrkERF6JCDkX5OFB438rBgVahcu8/nRyK02rehfItZ81nBF36 INpk7YtnWCAJxLAFciJkmLi611ZN/4QMchlAM/IeRHkZoI4Xw8FOi3HlnzthhgRvJ7MP nwpKGR0D5qLUklD34XgnQlUwsIeCgpxNEErEKrk8ctIAYFXzU6rDCv/n5LsBEHyv9Ypj cacdbBA5E4MI92PjykWmIeHJ8y0JcsH/dJqwS0upfooBRews3QuJRLIxbK9MicMnZavc SzVg== X-Gm-Message-State: AOJu0Yy8eJw0yLyaNbFduXQjMDUKEXHqc3pJoBvaIRlIWEPyjk37nFgA CP9NcaL5DKkWRzbjvlOOWdkFWw== X-Google-Smtp-Source: AGHT+IGsKoIFUtQIb3ztR/ylg1Yc1GphO+I2cp9J318HeLWvDHfxA13IVrTJXjmBlxGkIlxH0DSlHA== X-Received: by 2002:a17:90a:6f05:b0:268:6ed5:117c with SMTP id d5-20020a17090a6f0500b002686ed5117cmr2547722pjk.18.1691694171237; Thu, 10 Aug 2023 12:02:51 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id c30-20020a17090a492100b0026094c23d0asm1985840pjh.17.2023.08.10.12.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 12:02:50 -0700 (PDT) Date: Thu, 10 Aug 2023 12:02:50 -0700 From: Kees Cook To: Arnd Bergmann Cc: Andrew Morton , linux-kernel@vger.kernel.org, Masahiro Yamada , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Sami Tolvanen , linux-kbuild@vger.kernel.org Subject: Re: [PATCH 17/17] [RFC] Makefile.extrawarn: turn on missing-prototypes again Message-ID: <202308101202.EA83B53@keescook> References: <20230810141947.1236730-1-arnd@kernel.org> <20230810141947.1236730-18-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810141947.1236730-18-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 04:19:35PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Over the years we went from > 1000 of warnings to under 100 earlier > this year, and I sent patches to address all the ones that I saw with > compile testing randcom configs on arm64, arm and x86 kernels. This is a > really useful warning, as it catches real bugs when there are mismatched > prototypes. In particular with kernel control flow integrity enabled, > those are no longer allowed. > > Move the options out of the W=1 section to have them enabled by > default. > > Signed-off-by: Arnd Bergmann > --- > I'm sure there are still regressions with CONFIG_WERROR when this gets > turned on, but it's getting very close, so it might be best to already > enable this in linux-next but wait one extra merge window to have it in > mainline while the last fixes trickle in. > --- Thanks for chasing all of these down! Reviewed-by: Kees Cook -Kees -- Kees Cook