From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFC3C04A94 for ; Thu, 10 Aug 2023 20:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235712AbjHJUt7 (ORCPT ); Thu, 10 Aug 2023 16:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234022AbjHJUt5 (ORCPT ); Thu, 10 Aug 2023 16:49:57 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 779752733 for ; Thu, 10 Aug 2023 13:49:57 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7918997ad9fso20720939f.1 for ; Thu, 10 Aug 2023 13:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691700597; x=1692305397; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IrPtI7WuVK/oaLBJhxp0over27m1houzlRFCqoHRsZI=; b=FefyM5boM+iZbD5HCFP6q7YdNjfhM4Crf149F1xn2YjT84k7yzbFnUm4EO4WcJBcZ+ aEq9gMUJrhGCPkZaVrruWI0GixWkHHRk0W1/MSLywlOf6fFJM1mBanu5xUpziUnJymb6 wyMDdWSPzAnOugSUbmiwqmUPrwD+Vxc4coHCD6T4B3h9E7dP/vncsfUtROT2l1kYs4Bj HkVbnH6HdttJ4QgZB0j6943Pt0v6CrrXpVyV2ss+wRQ9mqjk5Vvo9SKj9Kok2GSWDeBT kPTFXzES0QKtjF2Jz0+naAIStbwstX0nqX+vIjBACvmYnlYxgerfm5rQEcA5u63Q2KVm qAZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691700597; x=1692305397; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IrPtI7WuVK/oaLBJhxp0over27m1houzlRFCqoHRsZI=; b=RCTltAuxLFQ5bP0Z9JMA5wvPRquE9hWqN8fLbMD7CYLPSigqmrr9OYq2fFaerGsIR9 oGZ4x1udjFZajVso1n0WYUzzXFelEV2FfHW++7TltEtl5hTX+NARs+EUTd070wyx+gut OKXfu1nC6V4JzYTDNVKh1kheEnC/AmD2vYjhM2u1MfqTIBlJN4hCWM0DtDAWlLWiNq0y pNLQ4uR1l1PJZwI+sqwgwEQ6VLepeeA/cBo4LryTpcTOnXJhvN0KijhYddZ5Jd4wGLRw DzC0Xa0lgot7yMmkYMCOrODlXTkKUcY7hjyDveREHvU08WVWd41glIV1AbSk9BTNX3zp 5kdg== X-Gm-Message-State: AOJu0YyjWspUeDYHdQ9rao8nkBKbteNeeEjpS5HIk6lPcKUE/V+VmXuF LhTsPxcwbrOWAER/tffK0eKN1g== X-Google-Smtp-Source: AGHT+IEwEFZIXKpAeifAuxh0Eqsxgobltmkf4dACqcHcGYNcVSpVavL7FAFg27OJnH28qQrTLzgHWA== X-Received: by 2002:a92:c54f:0:b0:348:b07e:fdac with SMTP id a15-20020a92c54f000000b00348b07efdacmr51572ilj.3.1691700596858; Thu, 10 Aug 2023 13:49:56 -0700 (PDT) Received: from google.com (161.74.123.34.bc.googleusercontent.com. [34.123.74.161]) by smtp.gmail.com with ESMTPSA id u9-20020a92da89000000b003487840f1d3sm658566iln.50.2023.08.10.13.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 13:49:56 -0700 (PDT) Date: Thu, 10 Aug 2023 20:49:53 +0000 From: Justin Stitt To: "Gustavo A. R. Silva" Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment Message-ID: <20230810204953.wwwvbl57m3cebf27@google.com> References: <52da391229a45fe3dbd5c43167cdb0701a17a361.1690938732.git.gustavoars@kernel.org> <20230810173404.jjuvqo5tv57en7pg@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810173404.jjuvqo5tv57en7pg@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 10, 2023 at 05:34:04PM +0000, Justin Stitt wrote: > On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote: > > One-element and zero-length arrays are deprecated. So, replace > > one-element array in struct i40e_profile_segment with flexible-array > > member. > > > > This results in no differences in binary output. > > > > Link: https://github.com/KSPP/linux/issues/335 > > Signed-off-by: Gustavo A. R. Silva > > --- > > drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Justin Stitt Whoops, this should be: Reviewed-by: Justin Stitt I did not test, I just verified there are no binary differences produced by this patch. > > > > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h > > index c3d5fe12059a..f7a984304b65 100644 > > --- a/drivers/net/ethernet/intel/i40e/i40e_type.h > > +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h > > @@ -1487,7 +1487,7 @@ struct i40e_profile_segment { > > struct i40e_ddp_version version; > > char name[I40E_DDP_NAME_SIZE]; > > u32 device_table_count; > > - struct i40e_device_id_entry device_table[1]; > > + struct i40e_device_id_entry device_table[]; > > }; > > > > struct i40e_section_table { > > -- > > 2.34.1 > >