Re: [PATCH v4 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller

Conor Dooley
2023-08-10T16:12:28Z

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

On Thu, Aug 10, 2023 at 05:54:26PM +0300, Aleksandr Shubin wrote:

> +allOf:
> + - $ref: pwm.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: allwinner,sun20i-r329-pwm
> +
> + then:
> + required:
> + - allwinner,pwm-channels
> +
> + else:
> + not:
> + required:
> + - allwinner,pwm-channels

Hmm, I realise I lead you astray a little. This can be reduced to
else:
properties:
allwinner,pwm-channels: false

If you respin, please update to that. Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]