From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7C1C001DB for ; Thu, 10 Aug 2023 05:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232409AbjHJFsm (ORCPT ); Thu, 10 Aug 2023 01:48:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbjHJFsk (ORCPT ); Thu, 10 Aug 2023 01:48:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 566BBDA; Wed, 9 Aug 2023 22:48:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D520364F45; Thu, 10 Aug 2023 05:48:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B74EDC43391; Thu, 10 Aug 2023 05:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691646519; bh=ca3j4GyefmTeFaiWxgzUmicjNwBwH0mAXY5Nth0Dg14=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Um2aoZckhhad5APXYRDC/4HENG/dPuJgG7gyynUbrd5QHl62omKYz/0i26KtGJfPy 5m6j5nB9v+bmyzwzG8464huaNB2FaHT8C1XECkjvjtj2Mr1HKukaWAXPvLVj92TQ7b M+tfgBgi/I75OdPu9McZLgqKEK8yAmiqY0fw6X+c= Date: Thu, 10 Aug 2023 07:48:36 +0200 From: Greg KH To: Shreenidhi Shedi Cc: dhowells@redhat.com, dwmw2@infradead.org, masahiroy@kernel.org, nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu, linux-kernel@vger.kernel.org, sshedi@vmware.com, linux-kbuild@vger.kernel.org Subject: Re: [PATCH v9 2/7] sign-file: inntroduce few new flags to make argument processing easy. Message-ID: <2023081050-ebony-appointee-9530@gregkh> References: <20230809172211.343677-1-yesshedi@gmail.com> <20230809172211.343677-3-yesshedi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230809172211.343677-3-yesshedi@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2023 at 10:52:05PM +0530, Shreenidhi Shedi wrote: > - Add some more options like help, x509, hashalgo to command line args > - This makes it easy to handle and use command line args wherever needed I do not understand this second line. Please read the kernel documentation for a great summary of how to write good kernel changelog text messages. It is usually the most difficult portion of writing the patch. thanks, greg k-h