Re: [PATCH] serial: 8250: drop lockdep annotation from serial8250_clear_IER()

Jiri Slaby
2023-08-14T10:22:12Z

On 14. 08. 23, 12:00, Petr Mladek wrote:
> I personally vote to keep it as is unless people see this warning
> on daily basis. After all, the lockdep splat is correct. The serial
> console might not work correctly in panic() when there is the race.

Sorry, but no, the warning is not correct at all. The code path
deliberately does NOT take the lock and calls a function which is
currently annotated that the lock is _always_ taken. Therefore, the
warning is clearly a false positive and I see no reason in keeping it.

Hopefully this is fixed as John described earlier. Until then, I see no
point bothering people with false alarms.

thanks,
--
js
suse labs