* [PATCH] staging: vt6655: Change camel case variables to snake case
@ 2023-08-05 3:57 Mingzai Sun
2023-08-09 12:21 ` Greg KH
2023-08-10 14:08 ` [PATCH v2] " Mingzai Sun
0 siblings, 2 replies; 5+ messages in thread
From: Mingzai Sun @ 2023-08-05 3:57 UTC (permalink / raw)
To: forest, gregkh; +Cc: linux-staging, linux-kernel, Mingzai Sun
Change camel case to snake case.
Issue found by checkpatch.
Signed-off-by: Mingzai Sun <szp2017@gmail.com>
---
drivers/staging/vt6655/srom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
index ee5ca4db74dc..812964ab68c5 100644
--- a/drivers/staging/vt6655/srom.c
+++ b/drivers/staging/vt6655/srom.c
@@ -49,7 +49,7 @@
* Parameters:
* In:
* iobase - I/O base address
- * byContntOffset - address of EEPROM
+ * by_contnt_offset - address of EEPROM
* Out:
* none
*
@@ -57,7 +57,7 @@
*
*/
unsigned char SROMbyReadEmbedded(void __iomem *iobase,
- unsigned char byContntOffset)
+ unsigned char by_contnt_offset)
{
unsigned short wDelay, wNoACK;
unsigned char byWait;
@@ -70,7 +70,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
- iowrite8(byContntOffset, iobase + MAC_REG_I2MTGAD);
+ iowrite8(by_contnt_offset, iobase + MAC_REG_I2MTGAD);
/* issue read command */
iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: vt6655: Change camel case variables to snake case
2023-08-05 3:57 [PATCH] staging: vt6655: Change camel case variables to snake case Mingzai Sun
@ 2023-08-09 12:21 ` Greg KH
2023-08-10 14:00 ` Leo Sun
2023-08-10 14:08 ` [PATCH v2] " Mingzai Sun
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2023-08-09 12:21 UTC (permalink / raw)
To: Mingzai Sun; +Cc: forest, linux-staging, linux-kernel
On Sat, Aug 05, 2023 at 11:57:39AM +0800, Mingzai Sun wrote:
> Change camel case to snake case.
> Issue found by checkpatch.
>
> Signed-off-by: Mingzai Sun <szp2017@gmail.com>
> ---
> drivers/staging/vt6655/srom.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index ee5ca4db74dc..812964ab68c5 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -49,7 +49,7 @@
> * Parameters:
> * In:
> * iobase - I/O base address
> - * byContntOffset - address of EEPROM
> + * by_contnt_offset - address of EEPROM
Why did you keep the unneeded "by" prefix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vt6655: Change camel case variables to snake case
2023-08-09 12:21 ` Greg KH
@ 2023-08-10 14:00 ` Leo Sun
0 siblings, 0 replies; 5+ messages in thread
From: Leo Sun @ 2023-08-10 14:00 UTC (permalink / raw)
To: Greg KH; +Cc: forest, linux-kernel, linux-staging
Greg KH <gregkh@linuxfoundation.org> 于2023年8月9日周三 20:21写道：
>
> On Sat, Aug 05, 2023 at 11:57:39AM +0800, Mingzai Sun wrote:
> > Change camel case to snake case.
> > Issue found by checkpatch.
> >
> > Signed-off-by: Mingzai Sun <szp2017@gmail.com>
> > ---
> > drivers/staging/vt6655/srom.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> > index ee5ca4db74dc..812964ab68c5 100644
> > --- a/drivers/staging/vt6655/srom.c
> > +++ b/drivers/staging/vt6655/srom.c
> > @@ -49,7 +49,7 @@
> > * Parameters:
> > * In:
> > * iobase - I/O base address
> > - * byContntOffset - address of EEPROM
> > + * by_contnt_offset - address of EEPROM
>
> Why did you keep the unneeded "by" prefix?
>
> thanks,
>
> greg k-h
OK, I will remove the "by" prefix in the second patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: vt6655: Change camel case variables to snake case
2023-08-05 3:57 [PATCH] staging: vt6655: Change camel case variables to snake case Mingzai Sun
2023-08-09 12:21 ` Greg KH
@ 2023-08-10 14:08 ` Mingzai Sun
2023-08-11 20:36 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Mingzai Sun @ 2023-08-10 14:08 UTC (permalink / raw)
To: forest, gregkh; +Cc: linux-staging, linux-kernel, Mingzai Sun
Remove the unneeded "by" prefix.
Signed-off-by: Mingzai Sun <szp2017@gmail.com>
---
Changes in v2:
- Change "by_contnt_offset" to "contnt_offset".
---
drivers/staging/vt6655/srom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
index 812964ab68c5..1b89d401a7eb 100644
--- a/drivers/staging/vt6655/srom.c
+++ b/drivers/staging/vt6655/srom.c
@@ -49,7 +49,7 @@
* Parameters:
* In:
* iobase - I/O base address
- * by_contnt_offset - address of EEPROM
+ * contnt_offset - address of EEPROM
* Out:
* none
*
@@ -57,7 +57,7 @@
*
*/
unsigned char SROMbyReadEmbedded(void __iomem *iobase,
- unsigned char by_contnt_offset)
+ unsigned char contnt_offset)
{
unsigned short wDelay, wNoACK;
unsigned char byWait;
@@ -70,7 +70,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
- iowrite8(by_contnt_offset, iobase + MAC_REG_I2MTGAD);
+ iowrite8(contnt_offset, iobase + MAC_REG_I2MTGAD);
/* issue read command */
iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] staging: vt6655: Change camel case variables to snake case
2023-08-10 14:08 ` [PATCH v2] " Mingzai Sun
@ 2023-08-11 20:36 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2023-08-11 20:36 UTC (permalink / raw)
To: Mingzai Sun; +Cc: forest, linux-staging, linux-kernel
On Thu, Aug 10, 2023 at 10:08:34PM +0800, Mingzai Sun wrote:
> Remove the unneeded "by" prefix.
>
> Signed-off-by: Mingzai Sun <szp2017@gmail.com>
> ---
> Changes in v2:
> - Change "by_contnt_offset" to "contnt_offset".
> ---
> drivers/staging/vt6655/srom.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index 812964ab68c5..1b89d401a7eb 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -49,7 +49,7 @@
> * Parameters:
> * In:
> * iobase - I/O base address
> - * by_contnt_offset - address of EEPROM
> + * contnt_offset - address of EEPROM
> * Out:
> * none
> *
> @@ -57,7 +57,7 @@
> *
> */
> unsigned char SROMbyReadEmbedded(void __iomem *iobase,
> - unsigned char by_contnt_offset)
> + unsigned char contnt_offset)
> {
> unsigned short wDelay, wNoACK;
> unsigned char byWait;
> @@ -70,7 +70,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
> iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
> for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
> iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
> - iowrite8(by_contnt_offset, iobase + MAC_REG_I2MTGAD);
> + iowrite8(contnt_offset, iobase + MAC_REG_I2MTGAD);
>
> /* issue read command */
> iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
> --
> 2.34.1
>
>
This patch does not apply to my tree at all :(
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-11 20:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-05 3:57 [PATCH] staging: vt6655: Change camel case variables to snake case Mingzai Sun
2023-08-09 12:21 ` Greg KH
2023-08-10 14:00 ` Leo Sun
2023-08-10 14:08 ` [PATCH v2] " Mingzai Sun
2023-08-11 20:36 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox