From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87466C04E69 for ; Sat, 12 Aug 2023 08:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235802AbjHLIVI (ORCPT ); Sat, 12 Aug 2023 04:21:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjHLIVH (ORCPT ); Sat, 12 Aug 2023 04:21:07 -0400 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E6642112; Sat, 12 Aug 2023 01:21:10 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL Global TLS RSA4096 SHA256 2022 CA1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 4AD9D30000861; Sat, 12 Aug 2023 10:21:08 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 29FA92ED8D0; Sat, 12 Aug 2023 10:21:08 +0200 (CEST) Date: Sat, 12 Aug 2023 10:21:08 +0200 From: Lukas Wunner To: Damien Le Moal Cc: Alistair Francis , bhelgaas@google.com, linux-pci@vger.kernel.org, Jonathan.Cameron@huawei.com, alex.williamson@redhat.com, christian.koenig@amd.com, kch@nvidia.com, gregkh@linuxfoundation.org, logang@deltatee.com, linux-kernel@vger.kernel.org, chaitanyak@nvidia.com, rdunlap@infradead.org, Alistair Francis Subject: Re: [PATCH v4] PCI/DOE: Expose the DOE protocols via sysfs Message-ID: <20230812082108.GD9469@wunner.de> References: <20230810163342.1059509-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2023 at 10:03:58AM +0900, Damien Le Moal wrote: > On 8/11/23 01:33, Alistair Francis wrote: > > Each DOE feature is exposed as a single file. The files are empty and > > the information is contained in the file name. > > s/feature/protocol ? DOE r1.1 replaced all occurrences of "protocol" with the term "feature" or "Data Object Type". PCIe r6.1 (which was published July 24) incorporated that change. So going forward the term "protocol" is deprecated in the DOE context. We should use the terms used by the (latest) PCIe Base Spec so that users can easily make the connection between the language in the spec and our code. Unfortunately this patch uses a mix of "protocol" and "feature". It should use the latter term exclusively. Thanks, Lukas