From: linux@treblig.org
To: smfrench@gmail.com, dave.kleikamp@oracle.com, tom@talpey.com,
pc@manguebit.com
Cc: linkinjeon@kernel.org, linux-cifs@vger.kernel.org,
jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org, krisman@collabora.com,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH v4 0/4] dedupe smb unicode files
Date: Sun, 13 Aug 2023 01:53:40 +0100 [thread overview]
Message-ID: <20230813005344.112955-1-linux@treblig.org> (raw)
From: "Dr. David Alan Gilbert" <linux@treblig.org>
The smb client and server code have (mostly) duplicated code
for unicode manipulation, in particular upper case handling.
Flatten this lot into shared code.
There's some code that's slightly different between the two, and
I've not attempted to share that - this should be strictly a no
behaviour change set.
In addition, the same tables and code are shared in jfs, however
there's very little testing available for the unicode in there,
so just share the raw data tables.
I suspect there's more UCS-2 code that can be shared, in the NLS code
and in the UCS-2 code used by the EFI interfaces.
Lightly tested with a module and a monolithic build, and just mounting
itself.
This dupe was found using PMD:
https://pmd.github.io/pmd/pmd_userdocs_cpd.html
Dave
Version 4
Put SPDX tag back to the way the tools like it, thanks to
Paulo Alcantara for explaining
Version 3
History comments simplification (Feedback from Tom Talpey)
Dr. David Alan Gilbert (4):
fs/smb: Remove unicode 'lower' tables
fs/smb: Swing unicode common code from smb->NLS
fs/smb/client: Use common code in client
fs/jfs: Use common ucs2 upper case table
fs/jfs/Kconfig | 1 +
fs/jfs/Makefile | 2 +-
fs/jfs/jfs_unicode.h | 17 +-
fs/jfs/jfs_uniupr.c | 121 -------
fs/nls/Kconfig | 8 +
fs/nls/Makefile | 1 +
fs/nls/nls_ucs2_data.h | 15 +
.../server/uniupr.h => nls/nls_ucs2_utils.c} | 156 +--------
fs/nls/nls_ucs2_utils.h | 285 +++++++++++++++
fs/smb/client/Kconfig | 1 +
fs/smb/client/cifs_unicode.c | 1 -
fs/smb/client/cifs_unicode.h | 330 +-----------------
fs/smb/client/cifs_uniupr.h | 239 -------------
fs/smb/server/Kconfig | 1 +
fs/smb/server/unicode.c | 1 -
fs/smb/server/unicode.h | 325 +----------------
16 files changed, 340 insertions(+), 1164 deletions(-)
delete mode 100644 fs/jfs/jfs_uniupr.c
create mode 100644 fs/nls/nls_ucs2_data.h
rename fs/{smb/server/uniupr.h => nls/nls_ucs2_utils.c} (50%)
create mode 100644 fs/nls/nls_ucs2_utils.h
delete mode 100644 fs/smb/client/cifs_uniupr.h
--
2.41.0
next reply other threads:[~2023-08-13 0:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 0:53 linux [this message]
2023-08-13 0:53 ` [PATCH v4 1/4] fs/smb: Remove unicode 'lower' tables linux
2023-08-13 0:53 ` [PATCH v4 2/4] fs/smb: Swing unicode common code from smb->NLS linux
2023-08-13 0:53 ` [PATCH v4 3/4] fs/smb/client: Use common code in client linux
2023-08-14 13:47 ` kernel test robot
2023-08-13 0:53 ` [PATCH v4 4/4] fs/jfs: Use common ucs2 upper case table linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230813005344.112955-1-linux@treblig.org \
--to=linux@treblig.org \
--cc=dave.kleikamp@oracle.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=krisman@collabora.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox