From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19783C41513 for ; Sun, 13 Aug 2023 09:19:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbjHMJTu (ORCPT ); Sun, 13 Aug 2023 05:19:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjHMJTs (ORCPT ); Sun, 13 Aug 2023 05:19:48 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6AEA2170C; Sun, 13 Aug 2023 02:19:51 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 37D9Jins008746; Sun, 13 Aug 2023 11:19:44 +0200 Date: Sun, 13 Aug 2023 11:19:44 +0200 From: Willy Tarreau To: Zhangjin Wu Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tanyuan@tinylab.org, thomas@t-8ch.de Subject: Re: [PATCH v2 3/7] selftests/nolibc: libc-test: use HOSTCC instead of CC Message-ID: <20230813091944.GH8237@1wt.eu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 12, 2023 at 04:30:25AM +0800, Zhangjin Wu wrote: > libc-test is mainly added to compare the behavior of nolibc to the > system libc, it is meaningless and error-prone with cross compiling. > > Let's use HOSTCC instead of CC to avoid wrongly use cross compiler when > CROSS_COMPILE is passed or customized. Indeed. This one is actually a fix for this one, I'll pick it separately as it's independent on this series: 85a0b029a1ce ("selftests/nolibc: add run-libc-test target") Thanks, Willy