From: Willy Tarreau <w@1wt.eu>
To: Zhangjin Wu <falcon@tinylab.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
tanyuan@tinylab.org, thomas@t-8ch.de
Subject: Re: [PATCH v2 5/7] selftests/nolibc: customize CROSS_COMPILE for all architectures
Date: Mon, 14 Aug 2023 09:16:21 +0200 [thread overview]
Message-ID: <20230814071621.GB14322@1wt.eu> (raw)
In-Reply-To: <20230813101805.10885-1-falcon@tinylab.org>
On Sun, Aug 13, 2023 at 06:18:05PM +0800, Zhangjin Wu wrote:
> > Given that we don't support mips64, I'd suggest to ust mips-linux-
> > instead here for now. That doesn't seem right to ask users to
> > download a toolchain for a different architecture than the one
> > supported just because we can adapt to it.
> >
>
> Agree very much, and the one below from patch 7/7 [1]:
>
> +CROSS_COMPILE_arm64 ?= aarch64-linux- aarch64-linux-gnu-
> +CROSS_COMPILE_arm ?= arm-linux-gnueabi- arm-none-eabi-
> +CROSS_COMPILE_mips ?= mips64-linux- mips64el-linux-gnuabi64-
>
> It should be:
>
> +CROSS_COMPILE_mips ?= mips-linux- mips-linux-gnu-gcc
>
> And if necessary, the mips64-linux- line in the commit message of [1] should be
> corrected too.
I just did that (and fixed mips-linux-gnu- instead of mips-linux-gnu-gcc
above).
Thanks,
Willy
next prev parent reply other threads:[~2023-08-14 7:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 20:27 [PATCH v2 0/7] selftests/nolibc: customize CROSS_COMPILE for all supported architectures Zhangjin Wu
2023-08-11 20:28 ` [PATCH v2 1/7] selftests/nolibc: allow use x86_64 toolchain for i386 Zhangjin Wu
2023-08-11 20:29 ` [PATCH v2 2/7] selftests/nolibc: allow use mips64 toolchain for mips Zhangjin Wu
2023-08-11 20:30 ` [PATCH v2 3/7] selftests/nolibc: libc-test: use HOSTCC instead of CC Zhangjin Wu
2023-08-13 9:19 ` Willy Tarreau
2023-08-11 20:31 ` [PATCH v2 4/7] selftests/nolibc: allow customize CROSS_COMPILE by architecture Zhangjin Wu
2023-08-11 20:32 ` [PATCH v2 5/7] selftests/nolibc: customize CROSS_COMPILE for all architectures Zhangjin Wu
2023-08-13 9:16 ` Willy Tarreau
2023-08-13 10:18 ` Zhangjin Wu
2023-08-14 7:16 ` Willy Tarreau [this message]
2023-08-11 20:33 ` [PATCH v2 6/7] selftests/nolibc: import cc-cross-prefix macro Zhangjin Wu
2023-08-11 20:34 ` [PATCH v2 7/7] selftests/nolibc: allow use cross toolchains from software repository Zhangjin Wu
2023-08-13 9:37 ` [PATCH v2 0/7] selftests/nolibc: customize CROSS_COMPILE for all supported architectures Willy Tarreau
2023-08-13 10:05 ` Zhangjin Wu
2023-08-14 7:18 ` Willy Tarreau
2023-08-14 7:38 ` Zhangjin Wu
2023-08-14 8:25 ` Willy Tarreau
2023-08-14 8:25 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814071621.GB14322@1wt.eu \
--to=w@1wt.eu \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=tanyuan@tinylab.org \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox