From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A139EEB64DD for ; Mon, 14 Aug 2023 20:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232344AbjHNURf (ORCPT ); Mon, 14 Aug 2023 16:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232428AbjHNURT (ORCPT ); Mon, 14 Aug 2023 16:17:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84706172E for ; Mon, 14 Aug 2023 13:17:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CF3864257 for ; Mon, 14 Aug 2023 20:17:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23229C433C8; Mon, 14 Aug 2023 20:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1692044234; bh=4HokLIG+fBcRWEGaR+eUHTaxkyTQTysIMRMz3aX8OIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wA+spL7MBqAkDRlJ/6m6TgWBJr8lvHpM+JCdn8XA4Tbydw+6haJPmQCFkCiIMYuQP b68jjbXVSziueeG+tRFVRHbvN0U14deph0MtLZQSHUyjV0BECxVZ0fmtC7h4CogvXa KKYlCYNhxIAwGohoVVMFCloLu9upXSr2MUp6temg= Date: Mon, 14 Aug 2023 22:17:10 +0200 From: Greg KH To: Alexon Oliveira Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: vme_user: fix check blank lines not necessary Message-ID: <2023081448-sustainer-prelaw-25a2@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 14, 2023 at 04:33:11PM -0300, Alexon Oliveira wrote: > Fixed all CHECK: Blank lines aren't necessary after an open brace '{' > and CHECK: Blank lines aren't necessary before a close brace '}' > as reported by checkpatch to adhere to the Linux kernel > coding-style guidelines. > > Signed-off-by: Alexon Oliveira > --- > drivers/staging/vme_user/vme.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c > index 5eb0d780c77f..c7c50406c199 100644 > --- a/drivers/staging/vme_user/vme.c > +++ b/drivers/staging/vme_user/vme.c > @@ -308,7 +308,6 @@ struct vme_resource *vme_slave_request(struct vme_dev *vdev, u32 address, > if (((slave_image->address_attr & address) == address) && > ((slave_image->cycle_attr & cycle) == cycle) && > (slave_image->locked == 0)) { > - > slave_image->locked = 1; > mutex_unlock(&slave_image->mtx); > allocated_image = slave_image; > @@ -510,7 +509,6 @@ struct vme_resource *vme_master_request(struct vme_dev *vdev, u32 address, > ((master_image->cycle_attr & cycle) == cycle) && > ((master_image->width_attr & dwidth) == dwidth) && > (master_image->locked == 0)) { > - > master_image->locked = 1; > spin_unlock(&master_image->lock); > allocated_image = master_image; > @@ -682,10 +680,8 @@ ssize_t vme_master_read(struct vme_resource *resource, void *buf, size_t count, > count = length - offset; > > return bridge->master_read(image, buf, count, offset); > - > } > EXPORT_SYMBOL(vme_master_read); > - This line needs to be there, checkpatch should not have complained about it. thanks, greg k-h