From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: kvm@vger.kernel.org, "Tian, Kevin" <kevin.tian@intel.com>,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH 2/4] vfio: use __aligned_u64 in struct vfio_device_gfx_plane_info
Date: Tue, 15 Aug 2023 08:38:17 -0400 [thread overview]
Message-ID: <20230815123817.GC3235352@fedora> (raw)
In-Reply-To: <ZNppcBX3FD2GdcKc@ziepe.ca>
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]
On Mon, Aug 14, 2023 at 02:50:40PM -0300, Jason Gunthorpe wrote:
> On Wed, Aug 09, 2023 at 05:02:46PM -0400, Stefan Hajnoczi wrote:
> > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > index de675d799c7d..ffab3536dc8a 100644
> > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> > @@ -1382,7 +1382,7 @@ static long intel_vgpu_ioctl(struct vfio_device *vfio_dev, unsigned int cmd,
> > intel_gvt_reset_vgpu(vgpu);
> > return 0;
> > } else if (cmd == VFIO_DEVICE_QUERY_GFX_PLANE) {
> > - struct vfio_device_gfx_plane_info dmabuf;
> > + struct vfio_device_gfx_plane_info dmabuf = {};
> > int ret = 0;
> >
> > minsz = offsetofend(struct vfio_device_gfx_plane_info,
> > @@ -1392,6 +1392,8 @@ static long intel_vgpu_ioctl(struct vfio_device *vfio_dev, unsigned int cmd,
> > if (dmabuf.argsz < minsz)
> > return -EINVAL;
> >
> > + minsz = min(minsz, sizeof(dmabuf));
> > +
>
> Huh?
>
> minsz = min(sizeof(dmabuf), dmabuf.argsz)
Thanks for catching this. I will fix it in the next revision.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-08-15 12:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 21:02 [PATCH 0/4] vfio: use __aligned_u64 for ioctl structs Stefan Hajnoczi
2023-08-09 21:02 ` [PATCH 1/4] vfio: trivially " Stefan Hajnoczi
2023-08-14 17:47 ` Jason Gunthorpe
2023-08-09 21:02 ` [PATCH 2/4] vfio: use __aligned_u64 in struct vfio_device_gfx_plane_info Stefan Hajnoczi
2023-08-10 3:22 ` Tian, Kevin
2023-08-10 14:24 ` Stefan Hajnoczi
2023-08-15 12:38 ` Stefan Hajnoczi
2023-08-14 17:50 ` Jason Gunthorpe
2023-08-15 12:38 ` Stefan Hajnoczi [this message]
2023-08-15 15:23 ` David Laight
2023-08-16 13:36 ` Stefan Hajnoczi
2023-08-09 21:02 ` [PATCH 3/4] vfio: use __aligned_u64 in struct vfio_iommu_type1_info Stefan Hajnoczi
2023-08-10 3:25 ` Tian, Kevin
2023-08-10 14:25 ` Stefan Hajnoczi
2023-08-14 17:52 ` Jason Gunthorpe
2023-08-09 21:02 ` [PATCH 4/4] vfio: use __aligned_u64 in struct vfio_device_ioeventfd Stefan Hajnoczi
2023-08-14 17:52 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815123817.GC3235352@fedora \
--to=stefanha@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox