Re: [PATCH 3/6] sched: Extract __schedule_loop()

Sebastian Andrzej Siewior
2023-08-16T12:21:00Z

On 2023-08-16 07:39:45 [-0400], Phil Auld wrote:
> I do. Admittedly I'm not an expert in how the wchan unwinding works but
> we have a slightly older version of this patch in our kernel (schedule_loop
> not __schedule_loop). When I added __sched it fixed it. Maybe there
> is something else but that seemed pretty obvious.
>
>
> /* Attach to any functions which should be ignored in wchan output. */
> #define __sched __section(".sched.text")
>
> I can't explain why you are not seeing it.

as peterz pointed out, it is marked __always_inline so the compiler
shouldn't make a separate function out of it.
Could you check with _this_ series? The schedule_loop variant is in RT
and does not have this inline thingy. So it would be good if the issue
you report actually exists in the series that has been posted.

> Cheers,
> Phil

Sebastian