From: Conor Dooley <conor.dooley@microchip.com>
To: Nick Hu <nick.hu@sifive.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <ajones@ventanamicro.com>,
<mason.huo@starfivetech.com>, <jeeheng.sia@starfivetech.com>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
Andy Chiu <andy.chiu@sifive.com>
Subject: Re: [PATCH] riscv: suspend: Add syscore ops for suspend
Date: Wed, 16 Aug 2023 13:33:30 +0100 [thread overview]
Message-ID: <20230816-mural-portion-5b22d90e83fd@wendy> (raw)
In-Reply-To: <20230816034009.2614866-1-nick.hu@sifive.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Wed, Aug 16, 2023 at 11:40:09AM +0800, Nick Hu wrote:
> Save and restore the FPU and vector states when system suspend. If a
> task is the one who performs the suspend flow and it also do some
> floating or vector operations before the suspend, we should save and
> restore the FPU states and vector states for this task.
>
> Signed-off-by: Nick Hu <nick.hu@sifive.com>
> Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
What was Andy's contribution to the patch?
Are you missing a co-developed-by tag?
Also, I'm a bit confused by the commit message due to a lack of
knowledge here - is this a fix or a new feature?
It reads as if things are not being saved/restored correctly, but
there's no "fix" related keywords in the commit message nor a Fixes:
tag.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-16 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 3:40 [PATCH] riscv: suspend: Add syscore ops for suspend Nick Hu
2023-08-16 12:33 ` Conor Dooley [this message]
2023-08-17 7:15 ` Nick Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816-mural-portion-5b22d90e83fd@wendy \
--to=conor.dooley@microchip.com \
--cc=ajones@ventanamicro.com \
--cc=andy.chiu@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=jeeheng.sia@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mason.huo@starfivetech.com \
--cc=nick.hu@sifive.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox