From: Atul Kumar Pant <atulpant.linux@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stern@rowland.harvard.edu, bagasdotme@gmail.com,
raychi@google.com, f.suligoi@asem.it, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH v1] drivers: usb: Replaces spaces with tabs for indentation.
Date: Wed, 16 Aug 2023 08:16:32 +0530 [thread overview]
Message-ID: <20230816024632.GA57274@atom0118> (raw)
In-Reply-To: <2023081515-glove-grub-96b0@gregkh>
On Tue, Aug 15, 2023 at 11:08:02PM +0200, Greg KH wrote:
> On Wed, Aug 16, 2023 at 02:14:39AM +0530, Atul Kumar Pant wrote:
> > This patch fixes following checkpatch.pl issue:
> > ERROR: code indent should use tabs where possible
> >
> > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > ---
> > drivers/usb/core/hub.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> You didn't mention "hub" in the subject?
>
> Again, please start out by doing work in drivers/staging/ to learn how
> to write good patches, before venturing out into other areas of the
> kernel. Fixing up whitespace issues in random kernel parts is not
> always encouraged.
Sure Greg, I'll check /drivers/staging/ and will avoid doing whitespace
changes in random kernel parts.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2023-08-16 2:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 20:44 [PATCH v1] drivers: usb: Replaces spaces with tabs for indentation Atul Kumar Pant
2023-08-15 21:08 ` Greg KH
2023-08-16 2:46 ` Atul Kumar Pant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816024632.GA57274@atom0118 \
--to=atulpant.linux@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=raychi@google.com \
--cc=shuah@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox