Re: [PATCH v3 1/4] dt-bindings: firmware: qcom,scm: support indicating SDI default state

Mukesh Ojha
2023-08-22T16:55:43Z

On 8/16/2023 10:15 PM, Robert Marko wrote:
> IPQ5018 has SDI (Secure Debug Image) enabled by TZ by default, and that
> means that WDT being asserted or just trying to reboot will hang the board
> in the debug mode and only pulling the power and repowering will help.
> Some IPQ4019 boards like Google WiFI have it enabled as well.
>
> So, lets add a boolean property to indicate that SDI is enabled by default
> and thus needs to be disabled by the kernel.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>

Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> ---
> Changes in v3:
> * Change the property so it indicates that SDI has been enabled by default
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index 4233ea839bfc..590bbbd61de5 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -89,6 +89,14 @@ properties:
> protocol to handle sleeping SCM calls.
> maxItems: 1
>
> + qcom,sdi-enabled:
> + description:
> + Indicates that the SDI (Secure Debug Image) has been enabled by TZ
> + by default and it needs to be disabled.
> + If not disabled WDT assertion or reboot will cause the board to hang
> + in the debug mode.
> + type: boolean
> +
> qcom,dload-mode:
> $ref: /schemas/types.yaml#/definitions/phandle-array