From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15820C3DA5C for ; Thu, 17 Aug 2023 15:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353382AbjHQPx2 (ORCPT ); Thu, 17 Aug 2023 11:53:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353371AbjHQPxR (ORCPT ); Thu, 17 Aug 2023 11:53:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6354630D4 for ; Thu, 17 Aug 2023 08:53:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E8D6B6242D for ; Thu, 17 Aug 2023 15:53:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 282D8C433C7; Thu, 17 Aug 2023 15:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692287595; bh=GI7bsJEXllKrx04dcqP4aAQbJejYQRK+vrqF+j3kz2k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AxuV6tErwgyi8sPCCLm58zhxU877tvhj+jq+WWyXMzzT2g/Fqcqoz5REAQQdr0fPq WUdyNHwncnCzDz64b0J19R1lk6T3HrsE3tpEt8D7Oj+qIch7l+7bbM8OEMPHobCIPF jMzn+PoKlcg2z0XNQuVqkJtysGBAUH9mBy9t9FjrcWx0qgqxLSndFXcHY1fa+JuiIU tg0CFwnO//Ddkt4LzR0z2SSlN3NlLnXvscOgPQKvCJc03fODY8378SRss3+NIPf9uV 2GtmI9yucV1IeFa/DSSAKVvV9KkOpF3dMqATGrLNOc9AIYytT+GVXYnLtB3CzWf5r2 ZQ82e505w/sdw== Date: Thu, 17 Aug 2023 08:53:14 -0700 From: Jakub Kicinski To: Justin Lai Cc: , , , , Subject: Re: [PATCH net-next v3 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code Message-ID: <20230817085314.1c8b567f@kernel.org> In-Reply-To: <20230815143756.106623-2-justinlai0215@realtek.com> References: <20230815143756.106623-1-justinlai0215@realtek.com> <20230815143756.106623-2-justinlai0215@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Aug 2023 22:37:55 +0800 Justin Lai wrote: > .../net/ethernet/realtek/rtase/rtase_main.c | 2696 +++++++++++++++++ > 5 files changed, 3127 insertions(+) Please try to make this patch smaller, usually breaking out ethtool operations and any offloads to separate patches does the trick. Keep in mind the driver must be operational after each patch.