From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780F1C2FC32 for ; Thu, 17 Aug 2023 13:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351484AbjHQNxY (ORCPT ); Thu, 17 Aug 2023 09:53:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243972AbjHQNwu (ORCPT ); Thu, 17 Aug 2023 09:52:50 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B51E210D; Thu, 17 Aug 2023 06:52:49 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5AC671F37F; Thu, 17 Aug 2023 13:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1692280368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yJxYoKOlaaNm5Uplf03K9+SNelS6VfaWNlFGWaSO/8g=; b=TFPHDsV4p/qJHx31Hmz/xhlJBk2YVyLPDEXrlKM+m4sY9cDR1aDmE/ptNe0cyrJdmfYdrC gqXG35/V2uIkPxE53IF2DmBqqjI2zu3OZCc/nxDhUjEyCX8IDv9asHbniV0+mATZEz/wqQ hzLa+EzQ9MM1EX2/l9ZCHn0PMMJbvoA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1692280368; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yJxYoKOlaaNm5Uplf03K9+SNelS6VfaWNlFGWaSO/8g=; b=ZqSIQav10wClwaztfZKfli6OOShBhvraqurL8rDdf3QUZ6dtKGlFw2f+IHxZjhjfSHp07p j2P3sLQb0Yi7vsDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C3F731358B; Thu, 17 Aug 2023 13:52:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TycXLC8m3mTbDwAAMHmgww (envelope-from ); Thu, 17 Aug 2023 13:52:47 +0000 Date: Thu, 17 Aug 2023 15:46:18 +0200 From: David Sterba To: Andy Shevchenko Cc: Christian Brauner , Dave Chinner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, David Sterba , kernel test robot Subject: Re: [PATCH v1 1/1] fs/affs: Rename local toupper() to fn() to avoid confusion Message-ID: <20230817134618.GT2420@suse.cz> Reply-To: dsterba@suse.cz References: <20230817121217.501549-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817121217.501549-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 17, 2023 at 03:12:17PM +0300, Andy Shevchenko wrote: > A compiler may see the collision with the toupper() defined in ctype.h: > > fs/affs/namei.c:159:19: warning: unused variable 'toupper' [-Wunused-variable] > 159 | toupper_t toupper = affs_get_toupper(sb); > > To prevent this from happening, rename toupper local variable to fn. > > Initially this had been introduced by 24579a881513 ("v2.4.3.5 -> v2.4.3.6") > in the history.git by history group. > > Reported-by: kernel test robot > Signed-off-by: Andy Shevchenko Added to affs tree, thanks.