drivers/scsi/mpt3sas/mpt3sas_base.c:5487: warning: Function parameter or member 'sas_addr' not described in 'mpt3sas_atto_get_sas_addr'

kernel test robot
2023-10-17T21:35:39Z

Hi Bradley,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 213f891525c222e8ed145ce1ce7ae1f47921cb9c
commit: 91cf186aa1bfea06c7438b16eb40a612a4c3b87a scsi: mpt3sas: Add support for ATTO ExpressSAS H12xx GT devices
date: 1 year, 2 months ago
config: x86_64-randconfig-x063-20230716 (https://download.01.org/0day-ci/archive/20231018/202310180526.lMLsejM1-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231018/202310180526.lMLsejM1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310180526.lMLsejM1-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/scsi/mpt3sas/mpt3sas_base.c:5487: warning: Function parameter or member 'sas_addr' not described in 'mpt3sas_atto_get_sas_addr'

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for DRM_I915_DEBUG_GEM
Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=y] && EXPERT [=y] && DRM_I915_WERROR [=n]
Selected by [y]:
- DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && DRM_I915 [=y] && EXPERT [=y] && !COMPILE_TEST [=n]

vim +5487 drivers/scsi/mpt3sas/mpt3sas_base.c

5477
5478 /**
5479 * mpt3sas_atto_get_sas_addr - get the ATTO SAS address from mfg page 1
5480 *
5481 * @ioc : per adapter object
5482 * @*sas_addr : return sas address
5483 * Return: 0 for success, non-zero for failure.
5484 */
5485 static int
5486 mpt3sas_atto_get_sas_addr(struct MPT3SAS_ADAPTER *ioc, union ATTO_SAS_ADDRESS *sas_addr)
> 5487 {
5488 Mpi2ManufacturingPage1_t mfg_pg1;
5489 Mpi2ConfigReply_t mpi_reply;
5490 struct ATTO_SAS_NVRAM *nvram;
5491 int r;
5492 __be64 addr;
5493
5494 r = mpt3sas_config_get_manufacturing_pg1(ioc, &mpi_reply, &mfg_pg1);
5495 if (r) {
5496 ioc_err(ioc, "Failed to read manufacturing page 1\n");
5497 return r;
5498 }
5499
5500 /* validate nvram */
5501 nvram = (struct ATTO_SAS_NVRAM *) mfg_pg1.VPD;
5502 r = mpt3sas_atto_validate_nvram(ioc, nvram);
5503 if (r)
5504 return r;
5505
5506 addr = *((__be64 *) nvram->SasAddr);
5507 sas_addr->q = cpu_to_le64(be64_to_cpu(addr));
5508 return r;
5509 }
5510

--
0-DAY CI Kernel Test Service