Re: [PATCH] rtc: pcf85363: Allow to wake up system without IRQ

Alexandre Belloni
2023-08-17T22:26:34Z

On 17/08/2023 11:02:43+0200, Mike Looijmans wrote:
> > My comment was also for device_init_wakeup(&client->dev, true);. I think
> > the easiest would be to move this block later on and set client->irq to
> > 0 when devm_request_threaded_irq fails.
> >
>
> Ah, clear. That also properly handles things when IRQ fails but
> wakeup-source was present. In table form:
>
> IRQ wakeup-source Call "device_init_wakeup" etc.
> N/A No No
> N/A Yes Yes
> OK No Yes
> OK Yes Yes

This case is forbidden, you must not have an interrupt property and
wakeup-source at the same time.

> FAIL No No
> FAIL Yes Yes

This is then also forbidden
>
> We still have to program the registers before registering the IRQ I think.

Yes, certainly.