From: Ferry Meng <mengferry@linux.alibaba.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ferry Meng <mengferry@linux.alibaba.com>
Subject: [PATCH] freevxfs: fix potential double brelse
Date: Fri, 18 Aug 2023 17:14:23 +0800 [thread overview]
Message-ID: <20230818091423.97536-1-mengferry@linux.alibaba.com> (raw)
Fix smatch warning:
fs/freevxfs/vxfs_bmap.c:170 vxfs_bmap_indir() warn: passing freed memory
'bp'
Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
diff --git a/fs/freevxfs/vxfs_bmap.c b/fs/freevxfs/vxfs_bmap.c
index de2a5bccb930..e2e143f182e1 100644
--- a/fs/freevxfs/vxfs_bmap.c
+++ b/fs/freevxfs/vxfs_bmap.c
@@ -126,6 +126,7 @@ vxfs_bmap_indir(struct inode *ip, long indir, int size, long block)
if (block < off) {
brelse(bp);
+ bp = NULL;
continue;
}
@@ -162,6 +163,7 @@ vxfs_bmap_indir(struct inode *ip, long indir, int size, long block)
BUG();
}
brelse(bp);
+ bp = NULL;
}
fail:
--
2.19.1.6.gb485710b
reply other threads:[~2023-08-18 9:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818091423.97536-1-mengferry@linux.alibaba.com \
--to=mengferry@linux.alibaba.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox