From: Heiko Carstens <hca@linux.ibm.com>
To: Christian Borntraeger <borntraeger@linux.ibm.com>,
Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] checkpatch: recognise NOKPROBE_SYMBOL for blank line detection after function/struct/union/enum
Date: Fri, 18 Aug 2023 16:36:23 +0200 [thread overview]
Message-ID: <20230818143623.24849-A-hca@linux.ibm.com> (raw)
In-Reply-To: <20230120114649.117018-1-borntraeger@linux.ibm.com>
On Fri, Jan 20, 2023 at 12:46:49PM +0100, Christian Borntraeger wrote:
> NOKPROBE_SYMBOL should be treated like EXPORT_SYMBOL to avoid
> false positives.
>
> Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 78cc595b98ce..037acbcee0e1 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3995,6 +3995,7 @@ sub process {
> $line =~ /^\+/ &&
> !($line =~ /^\+\s*$/ ||
> $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param)/ ||
> + $line =~ /^\+\s*NOKPROBE_SYMBOL/ ||
> $line =~ /^\+\s*MODULE_/i ||
> $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
> $line =~ /^\+[a-z_]*init/ ||
Seven months later... Joe, is there actually anything that prevents this
from being merged?
You were the only one who replied back then:
https://lore.kernel.org/lkml/20230120114649.117018-1-borntraeger@linux.ibm.com/
And it is kind of not obvious what the result was.
prev parent reply other threads:[~2023-08-18 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 11:46 [PATCH 1/1] checkpatch: recognise NOKPROBE_SYMBOL for blank line detection after function/struct/union/enum Christian Borntraeger
2023-01-20 16:10 ` Joe Perches
2023-01-24 12:16 ` Christian Borntraeger
2023-08-18 14:36 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818143623.24849-A-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=borntraeger@linux.ibm.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox