From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D6EEE49AB for ; Sat, 19 Aug 2023 06:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245578AbjHSGKT (ORCPT ); Sat, 19 Aug 2023 02:10:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245277AbjHSGJq (ORCPT ); Sat, 19 Aug 2023 02:09:46 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C784420F for ; Fri, 18 Aug 2023 23:09:44 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-58daaa2ba65so24813747b3.1 for ; Fri, 18 Aug 2023 23:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692425384; x=1693030184; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7CHNiRakjnSFrwZPm4w1kCxtDJ8+gWDLA3nwnMrmLA0=; b=5WZpVYez9PBWui0B26Zfb8zt7IV6megCpewMZYC+ulTfA4HwwZOoAHBUZGhzT7w8QH jftRuVHlgopl/lzcc/vXiXBfjfPh8V5ytVVNKoa/pfG0GbqIkpnUGRISsSn16T5PqUnQ uCt3alcMeQ4r1xTzhGYgxm1jYD/sxmXgLfxNDAhynQz88guSjIb0cA01QABFAxO7/U3w jLxYI3x8Y3Sjfz3pa2m2DDE56lcuR81mI9UKdxaNMK3ADU+9ZQLUa0Mmd5t+voelUveV x+3VanSU21kJtNvqCO1mmCsgVbysDONggEnkkvInX8SMXIXhhM1jX05s541R3b0gqiJH IXSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692425384; x=1693030184; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7CHNiRakjnSFrwZPm4w1kCxtDJ8+gWDLA3nwnMrmLA0=; b=KigErI/46TC1lFSCdrfS1ZXJ4WeWfuEL8ySCDBrAONMAyNGoN8HYG2MUzWqNErWNdh dpgyNWv4hLebfyyBfheMn0Gn1eOExf2Zdmtkq0/VC+ciscuLT83Ung6vKF1BlJ3p49gl gBRmJnAHmXWJOb190oG39aRc/bdAi/uaIVtbKAzEVaXkcjpNKaRPACMaGKNW7uyPvlmj ynwRDDJHyhjXkQocjCqCMfkl3Db1hgPNZJSUZtkd4LxRap00/XmaJx0SOeF5obtZAeKZ Pu4Fx5hsgWfPpHe7JjJNmQVIiaJJriTLjeXbVjcMgr+zcPIGp5NsQCeN0phJff2CZEJ1 he6A== X-Gm-Message-State: AOJu0YymtcIEMK+tSJzp5N+NY+KJbMJuy1doVPwwbIlPVD/aADLGC/xS pjC6Zbw793AxWdOE8mSNCAyNtRZljrCBxZ7ICRyaJUBjGjonBYD9surAT03015Uz0c6bkX8kDPh lRtSdVqOIq8LTwKo+sBCdSGhsk/ekQvcAHMN5rQhzzcy0f2Pn9OxCW4YsjpyYcfxy+2wV2Qw= X-Google-Smtp-Source: AGHT+IH6bsTvzrf5MZy5XKS4cNOc6EPPwJK8oOKSWaR1iS2xwh86/tM7ZLRyG4VGZXwp+T1qJliPYThNf9x4 X-Received: from jstultz-noogler2.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:600]) (user=jstultz job=sendgmr) by 2002:a81:b707:0:b0:579:f832:74b with SMTP id v7-20020a81b707000000b00579f832074bmr10079ywh.10.1692425383720; Fri, 18 Aug 2023 23:09:43 -0700 (PDT) Date: Sat, 19 Aug 2023 06:08:43 +0000 In-Reply-To: <20230819060915.3001568-1-jstultz@google.com> Mime-Version: 1.0 References: <20230819060915.3001568-1-jstultz@google.com> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog Message-ID: <20230819060915.3001568-10-jstultz@google.com> Subject: [PATCH v5 09/19] locking/mutex: Switch to mutex handoffs for CONFIG_PROXY_EXEC From: John Stultz To: LKML Cc: Peter Zijlstra , Joel Fernandes , Qais Yousef , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Youssef Esmat , Mel Gorman , Daniel Bristot de Oliveira , Will Deacon , Waiman Long , Boqun Feng , "Paul E . McKenney" , kernel-team@android.com, Valentin Schneider , "Connor O'Brien" , John Stultz Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra Just the very earliest framework logic to provide the config option and switch to using mutex handoffs. Cc: Joel Fernandes Cc: Qais Yousef Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Valentin Schneider Cc: Steven Rostedt Cc: Ben Segall Cc: Zimuzo Ezeozue Cc: Youssef Esmat Cc: Mel Gorman Cc: Daniel Bristot de Oliveira Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: "Paul E . McKenney" Cc: kernel-team@android.com Signed-off-by: Peter Zijlstra (Intel) [rebased, added comments and changelog] Signed-off-by: Juri Lelli [Fixed rebase conflicts] [squashed sched: Ensure blocked_on is always guarded by blocked_lock] Signed-off-by: Valentin Schneider [fix rebase conflicts, various fixes & tweaks commented inline] [squashed sched: Use rq->curr vs rq->proxy checks] Signed-off-by: Connor O'Brien [jstultz: Split out only the very basic initial framework for proxy logic from a larger patch.] Signed-off-by: John Stultz --- v5: Split out from core proxy patch --- kernel/Kconfig.locks | 2 +- kernel/locking/mutex.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/Kconfig.locks b/kernel/Kconfig.locks index 4198f0273ecd..791c98f1d329 100644 --- a/kernel/Kconfig.locks +++ b/kernel/Kconfig.locks @@ -226,7 +226,7 @@ config ARCH_SUPPORTS_ATOMIC_RMW config MUTEX_SPIN_ON_OWNER def_bool y - depends on SMP && ARCH_SUPPORTS_ATOMIC_RMW + depends on SMP && ARCH_SUPPORTS_ATOMIC_RMW && !PROXY_EXEC config RWSEM_SPIN_ON_OWNER def_bool y diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c index 687009eca2d1..5125bbab4119 100644 --- a/kernel/locking/mutex.c +++ b/kernel/locking/mutex.c @@ -913,6 +913,10 @@ static noinline void __sched __mutex_unlock_slowpath(struct mutex *lock, unsigne mutex_release(&lock->dep_map, ip); +#ifdef CONFIG_PROXY_EXEC + /* Always force HANDOFF for Proxy Exec for now. Revisit. */ + owner = MUTEX_FLAG_HANDOFF; +#else /* CONFIG_PROXY_EXEC */ /* * Release the lock before (potentially) taking the spinlock such that * other contenders can get on with things ASAP. @@ -935,6 +939,7 @@ static noinline void __sched __mutex_unlock_slowpath(struct mutex *lock, unsigne return; } } +#endif /* CONFIG_PROXY_EXEC */ raw_spin_lock_irqsave(&lock->wait_lock, flags); debug_mutex_unlock(lock); -- 2.42.0.rc1.204.g551eb34607-goog