From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: core: Remove unused PORT_* definitions
Date: Sat, 19 Aug 2023 11:53:36 +0200 [thread overview]
Message-ID: <2023081954-situation-massive-269b@gregkh> (raw)
In-Reply-To: <20230818111229.764380-1-andriy.shevchenko@linux.intel.com>
On Fri, Aug 18, 2023 at 02:12:29PM +0300, Andy Shevchenko wrote:
> For the last couple of years Linux kernel got rid of a few architectures
> and many platforms. Hence some PORT_* definitions in the serial_core.h
> become unused and redundant. Remove them for good.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/uapi/linux/serial_core.h | 43 ++------------------------------
> 1 file changed, 2 insertions(+), 41 deletions(-)
>
> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> index 281fa286555c..c361570a334f 100644
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -28,7 +28,7 @@
> */
> #define PORT_NS16550A 14
> #define PORT_XSCALE 15
> -#define PORT_RM9000 16 /* PMC-Sierra RM9xxx internal UART */
> +
I'm all for removing these defines, but are you sure they are not used
in any userspace code? Ususally a debian code search is good enough
"proof" of this, did you do that?
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-19 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 11:12 [PATCH v1 1/1] serial: core: Remove unused PORT_* definitions Andy Shevchenko
2023-08-19 9:53 ` Greg Kroah-Hartman [this message]
2023-08-21 8:14 ` Andy Shevchenko
2023-08-21 8:22 ` Andy Shevchenko
2023-08-21 8:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081954-situation-massive-269b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox