From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113A7EE49AC for ; Sun, 20 Aug 2023 02:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbjHTCzP (ORCPT ); Sat, 19 Aug 2023 22:55:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229862AbjHTCy7 (ORCPT ); Sat, 19 Aug 2023 22:54:59 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 876DC6EBB for ; Sat, 19 Aug 2023 19:45:25 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-686be3cbea0so2210008b3a.0 for ; Sat, 19 Aug 2023 19:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692499525; x=1693104325; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1mm5o8vsDqtJgWgv9cexSZ5HfDXLmENIR7pd/RZCi7E=; b=QF4T3t8kAsJg3A+ftbt35NVWqk1oPaEvm7z0M8UyD03BVljdR3EVvfWllOrmm44cNW yU0PUfBTcf7oYB5sJn23GomgRZyv/+IqvWz2yfklLy3yVghdDVOZZlh2a4q7rmC8Jqap U2Nq7Us3hWOc1YHKTDXE0nlZ6JuClOeDFVnZg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692499525; x=1693104325; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1mm5o8vsDqtJgWgv9cexSZ5HfDXLmENIR7pd/RZCi7E=; b=XCwN+3trRWJ0hornSy5SK5Hyy/r69o8WL4EOsbNAJuL9NnrAk5r7BsBMGAEzrVX3xW 5O4FAAAJHO9iiiddFu7LmI+KN1jzdulrexk+ElC1vEeYSGzWR0tV4REDmSx0nH+n9JA2 3Cd+heqWFxNJ98ANe4bzPWGajJIfamlArqo35+9wMzG1z3u4nJIW1xiA4aI5qA3aqLTR 2tvZ2FDPASXsQKnf3gt0kRrIRcSfwWGgUpvlmwAlLd+hMKHZuelFlxYYnoRS6tOM1fuD bA72o4wLuDZZnzKfKG5h2afyGgyrmX4WROcq/xztk2+9zOcaVv0K2IVqSj8Gi0FUxbqw 9jRA== X-Gm-Message-State: AOJu0Yxkw+ePmSqZ7vBk+dms1e7HZQLhtrMJJO8TxO57QxLMalw/f1hl oJ3R6Xik7xjlisJ8q3O5iXueFA== X-Google-Smtp-Source: AGHT+IG42FLuKrdBKHw4/34k/LFZH3xW+oxA3C97LCsaTYhQ/3rqcwOr9i+z2KUPrmEeF4wHeR8kGA== X-Received: by 2002:a05:6a20:938a:b0:140:d536:d434 with SMTP id x10-20020a056a20938a00b00140d536d434mr5183268pzh.10.1692499524799; Sat, 19 Aug 2023 19:45:24 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id d5-20020aa78145000000b00687a4b70d1esm3747974pfn.218.2023.08.19.19.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Aug 2023 19:45:24 -0700 (PDT) Date: Sun, 20 Aug 2023 11:45:19 +0900 From: Sergey Senozhatsky To: Masahiro Yamada Cc: Sergey Senozhatsky , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Jonathan Corbet , Tomasz Figa , linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] kconfig: introduce listunknownconfig Message-ID: <20230820024519.GK907732@google.com> References: <20230817012007.131868-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/08/20 08:19), Masahiro Yamada wrote: > > Example: > > Suppose old .config has the following two options which > > were removed from the recent kernel: > > > > $ cat .config > > CONFIG_DISABLE_BUGS=y > > > > Running `make listunknownconfig` produces the following > > list of unrecognized symbols: > > > > .config:6:warning: unknown symbol: DISABLE_BUGS > > .config:7:warning: unknown unset symbol: ENABLE_WINAPI > > > > Signed-off-by: Sergey Senozhatsky > > > A new target is not what I like to see. > > > We decided to add KCONFIG_VERBOSE, which will be used to > warn options accidentally disabled or downgraded. That doesn't seem cover the cases that I'm concerned with. I don't see anything related to "!sym" in the patch. What will KCONFIG_VERBOSE do if it reads the following config file? // assuming that both config options were valid and existed in the old // kernel, but were removed/renamed in the new kernel $ cat .config CONFIG_DISABLE_BUGS=y # CONFIG_ENABLE_WINAPI is not set I'd like to see warnings for both lines, even for config that is not set, because it maybe we set by a build script depending on USE flags for instance, so that build target may still refer to non-existent config.