Re: [PATCH] riscv: dts: thead: set dma-noncoherent to soc bus

Drew Fustini
2023-09-04T18:50:15Z

On Mon, Sep 04, 2023 at 10:45:43PM +0800, Jisheng Zhang wrote:
> On Sun, Sep 03, 2023 at 04:32:21PM -0700, Drew Fustini wrote:
> > On Sun, Aug 20, 2023 at 07:53:53PM +0800, Jisheng Zhang wrote:
> > > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> > > dma coherent, so set dma-noncoherent to reflect this fact.
> > >
> > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > > ---
> > > arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> > > index 56a73134b49e..58108f0eb3fd 100644
> > > --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> > > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> > > @@ -139,6 +139,7 @@ soc {
> > > interrupt-parent = <&plic>;
> > > #address-cells = <2>;
> > > #size-cells = <2>;
> > > + dma-noncoherent;
> > > ranges;
> > >
> > > plic: interrupt-controller@ffd8000000 {
> > > --
> > > 2.40.1
> > >
> >
> > Tested-by: Drew Fustini <dfustini@baylibre.com>
> >
> > I tried this on the BeagleV Ahead. They system booted as expected and I
> > did not notice any problems in the boot log.
> >
> > Are there other patches such as the dwmac series that I should test this
> > with?
>
> Hmm, this patch is necessary to test dwmac, emmc ;)

Would you be able to share list of patches you are currently using so
that I can apply them all?

Do you have any changes in the device tree that you are using that is
not in mainline?

I added the linux,cma node [1] with compatible "shared-dma-pool" from
light.dtsi in the thead sdk, but that did not seem to make a difference.

thanks,
drew

[1] https://git.beagleboard.org/beaglev-ahead/kernel/-/blob/master/arch/riscv/boot/dts/thead/light.dtsi#L88